Re: [PATCH] selftests/mm: Drop duplicate test_seal_mprotect_two_vma_with_gap() call

Hongfu Li <[email protected]> Tue, 4 Aug 2026 16:51:57 +0800
Newsgroups gmane.linux.kernel,gmane.linux.kernel.mm
Message-ID <[email protected]>
On 8/4/26 4:24 PM, Lorenzo Stoakes (ARM) wrote:
> On Tue, Aug 04, 2026 at 09:20:37AM +0100, Lorenzo Stoakes (ARM) wrote:
>> On Tue, Aug 04, 2026 at 02:24:40PM +0800, Hongfu Li wrote:
>>> From: Hongfu Li <[email protected]>
>>>
>>> mseal_test main() invokes test_seal_mprotect_two_vma_with_gap() twice.
>>> The second run repeats all assertions with no benefit. Drop the
>>> duplicate call.
>>>
>>> Signed-off-by: Hongfu Li <[email protected]>
>> :))
>>
>> LGTM so
>>
>> Reviewed-by: Lorenzo Stoakes (ARM) <[email protected]>
> Sorry Pedro mentioned off-list that you need to update the number of tests
> specified, e.g.:
>
> -	ksft_set_plan(88);
> +	ksft_set_plan(87);
>
> In main().
>
> Update that and send a respin and you can attach my tag to it.
Thanks a lot for your review. I will adjust ksft_set_plan() from 88 to 
87 in main() and
send a respin carrying your Reviewed-by.

-- 
Best regards,
Hongfu