Re: [PATCH v3 04/26] x86/mm: split out preallocate_sub_pgd()

On Sun Aug 2, 2026 at 5:13 PM BST, Mike Rapoport wrote:
> On Sun, Jul 26, 2026 at 10:22:37PM +0000, Brendan Jackman wrote:
>> This code will be needed elsewhere in a following patch. Split out the
>> trivial code move for easy review.
>> 
>> As a side effect, change the logging slightly: instead of directly
>> reporting the level of the failure in panic(), show a generic panic
>> message, will be preceded by a separate warn that reports the level of
>> the failure. This is a simple way to have this helper suit the needs of
>> its new user as well as the existing one.
>> 
>> Other than logging, no functional change intended.
>> 
>> Signed-off-by: Brendan Jackman <[email protected]>
>> ---
>>  arch/x86/include/asm/pgalloc.h |  3 +++
>>  arch/x86/mm/init_64.c          | 44 +++++++-----------------------------------
>>  arch/x86/mm/pgtable.c          | 38 ++++++++++++++++++++++++++++++++++++
>>  3 files changed, 48 insertions(+), 37 deletions(-)
>> 
>> diff --git a/arch/x86/include/asm/pgalloc.h b/arch/x86/include/asm/pgalloc.h
>> index c88691b15f3c6..2aba6cfabf495 100644
>> --- a/arch/x86/include/asm/pgalloc.h
>> +++ b/arch/x86/include/asm/pgalloc.h
>> @@ -2,6 +2,7 @@
>>  #ifndef _ASM_X86_PGALLOC_H
>>  #define _ASM_X86_PGALLOC_H
>>  
>> +#include <linux/printk.h>
>
> I think this should go to arch/x86/mm/pgtable.c. pgalloc.h does not need
> printk symbols.

Yeah thanks, no idea what I was thinking here.