Re: [PATCH v4 4/7] mm/khugepaged: fix outdated comments

Lance Yang <[email protected]>
Newsgroups gmane.linux.documentation,gmane.linux.kernel.mm,gmane.linux.kernel
Message-ID <[email protected]>
On Tue, Aug 11, 2026 at 06:48:36AM -0600, Nico Pache (Red Hat) wrote:
>Fix comment in collapse_scan_pmd() that still described the old
>folio_mapcount() > folio_ref_count() check and a "512" false-positive
>scenario. The code now uses folio_expected_ref_count() != folio_ref_count()
>which doesn't suffer from the same limitation.
>
>Fix comment in collapse_huge_page() that referenced ptep_clear_flush,
>when the code actually uses pmdp_collapse_flush.
>
>Fix comment in __collapse_huge_page_swapin() that referenced the old
>function name khugepaged_scan_pmd, now collapse_scan_pmd.
>
>Also clean up some simple typos and stale terminology (mmap_sem ->
>mmap_lock, PG_lock -> folio lock, page -> folio, grammar).
>
>We also clarify a comment regarding where the max_ptes_none check is
>deferred to in mthp_collapse() from the original collapse_scan_pmd check.
>
>Update all comments that references a function to include parentheses.
>
>Acked-by: Usama Arif <[email protected]>
>Assisted-by: Cursor(claude-sonnet-4):4.6
>Acked-by: David Hildenbrand (Arm) <[email protected]>
>Signed-off-by: Nico Pache (Red Hat) <[email protected]>
>---

Reviewed-by: Lance Yang <[email protected]>
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.