Re: [PATCH mm-unstable v3 1/2] mm/vmscan: fix missing NR_ISOLATED counter update in MGLRU reclaim path
Barry Song <[email protected]>
| Newsgroups | gmane.linux.kernel,gmane.linux.kernel.mm |
|---|---|
| Message-ID | <CAGsJ_4w4HcqBL7X9whgTXqHdkDkwg0u6SSaiaOVhn7wfJx+2Bw@mail.gmail.com> |
On Tue, Aug 18, 2026 at 8:49 PM Hui Zhu <[email protected]> wrote: > > From: Hui Zhu <[email protected]> > > MGLRU evict_folios() isolates folios from the LRU without updating > the NR_ISOLATED_ANON/FILE counters, unlike the legacy > shrink_inactive_list() path. This causes compaction's > too_many_isolated() check to under-count isolated pages when MGLRU > reclaim is active. > > Add NR_ISOLATED counter updates in evict_folios(): increment after > isolate_folios() and decrement after all retry passes complete, using > the existing nr_isolated which holds the original isolated count. > > Signed-off-by: Hui Zhu <[email protected]> > Reviewed-by: Baolin Wang <[email protected]> > --- LGTM, thanks! Reviewed-by: Barry Song <[email protected]>