Re: Fwd: Question about LiS

JooHwan,

Can you contribute a patch against LiS-2.16.18-19?

--brian

On Mon, 24 Jan 2005, Dave Grothe wrote:

> 
>      From: =?ks_c_5601-1987?B?udrB1siv?= <[email protected]>
>      To: <[email protected]>
>      Subject: Question about LiS
>      Date: Sat, 22 Jan 2005 19:28:24 +0900
>      X-Mailer: Microsoft Outlook Express 6.00.3790.181
>      X-Assp-Received-RBL:  pass  (ASSP-nospam:  local  policy) rbl=none;
>      client-ip=218.152.55.59;
>      X-Assp-Spam-Prob: 0.00000
>      X-MIME-Autoconverted:  from  base64  to  8bit  by email.gcom.com id
>      j0MASMIw003893
>      Hi~
>      I  am  a  programmer from Korea. So please forgive me about my poor
>      English.
>      I am working on some project of multicasting based on LiS.
>      But  my  code  was  not  working as my wishes, so I looked into LiS
>      code.
>      And I found that there is no check for registered multicast address
>      in eth_ii_want() in ldl.c, while there is in eth_8022_want().
>      Is there some reason about this?
>      I  copied  and  pasted  the  checking  code on eth_ii_want() and it
>      worked.
>      STATIC int eth_ii_want(struct dl *dl, unsigned char *fr, int len)
>      {
>      ....
>          if (!memcmp(fr, dl->ndev->dev->dev_addr, 6))
>              return 1;
>          if (!memcmp(fr, dl->ndev->dev->broadcast, 6))
>              return 1;
>          /*
>           * Check the registered multicast address list ...
>           * pasted from eth_8022_want().
>           */
>          struct dev_mc_list *dmi = dl->ndev->dev->mc_list;
>          while (dmi != NULL)
>          {
>              if (!memcmp(fr, dmi->dmi_addr, 6))
>                     return 1;
>              else dmi = dmi->next;
>          }
>          return 0;
>      }
>      Please  tell  me  why  there  is  no  checking  code for registered
>      multicast address in eth_ii_want().
>      Thanks,
>      JooHwan.

-- 
Brian F. G. Bidulock    ¦ The reasonable man adapts himself to the ¦
[email protected]    ¦ world; the unreasonable one persists in  ¦
http://www.openss7.org/ ¦ trying  to adapt the  world  to himself. ¦
                        ¦ Therefore  all  progress  depends on the ¦
                        ¦ unreasonable man. -- George Bernard Shaw ¦