RE: missing symbols...

 
Hi All,

I did check 2.6.10 kernel. cdev_put() and cdev_get() are not exported. 

But sleep_on() and sleep_on_timeout() are still defined as well as
exported in kernel 2.6.10 unlike RHEL4 or FC-3.

Since some of these symbols are deprecated or obsoleted and hard to
pursue these kernel folks, can we use sleep_on_interruptible() instead
of sleep_on() in LiS.

In the case of cdev_put can we stick the code in LiS

void cdev_put(struct cdev *p)
{
        if (p) {
                kobject_put(&p->kobj);
                module_put(p->owner);
        }
}

BTW: I tried these changes with kernel 2.6.8 and worked fine for me. I
may not be testing complete functionality -:). It did work on FC-3 as
well. I am yet to validate RHEL 4.

Only other change required was (inode->i_cdev->kobj.refcount) to
(inode->i_cdev->kobj.kref.refcount) as already pointed out by someone.

Other suggestion is cleaning up all deprecated functions in LiS. This
might save us in the longer run.

Thanks
Ed

-----Original Message-----
From: Brian F. G. Bidulock [mailto:[email protected]] 
Sent: Wednesday, February 09, 2005 6:29 PM
To: Dave Grothe
Cc: Wm. Reich; Rodrigues, Edward; LiS Mailing List
Subject: Re: [Linux-streams] missing symbols...

Dave,

What I meant was that, as Arjan was the one compiling the unused list
and doing the removing, that the activity is likely related to RH.  But
then what's the difference anymore.

--brian

On Wed, 09 Feb 2005, Dave Grothe wrote:

> 
>    At 05:16 PM 2/9/2005, Brian F. G. Bidulock wrote:
> 
>      Wm.,
>      Well, Arjan is still the RedHat kernel build captain isn't he?
> 
>    Yes.  Maybe if someone were to download the most recent 2.6 kernel
and
>    check  the  exported  symbols  for  the missing ones we would have
the
>    answer to the question.
>    -- Dave
> 

-- 
Brian F. G. Bidulock    | The reasonable man adapts himself to the |
[email protected]    | world; the unreasonable one persists in  |
http://www.openss7.org/ | trying  to adapt the  world  to himself. |
                        | Therefore  all  progress  depends on the |
                        | unreasonable man. -- George Bernard Shaw |