RE: missing symbols...
Dave Grothe <[email protected]>
| Newsgroups | gmane.linux.kernel.streams |
|---|---|
| Message-ID | <[email protected]> |
Well, isn't that special!! So no driver in the kernel source needs to do DMA syncing, so they just eliminate the function so nobody will be able to do so in the future. That function, by the way, had a brain-damaged parameter list. You passed the DMA handle and a size parameter, but not an offset within the region. So if you just want to sync a little 32 byte descriptor structure out of 2 megs of mapped memory you end up having to sync the whole thing -- or mapping each tiny piece individually. Somebody forgot to read the Solaris DKI when they invented these functions. I repeat: "Are there any grownups out there?" -- Dave At 08:35 AM 2/14/2005, Rodrigues, Edward wrote: >Here are some more from 2.6.10. These are LiS DKI specific, so no big deal > > > >streams: Unknown symbol pci_dma_sync_sg > >streams: Unknown symbol pci_dma_sync_single > >streams: Unknown symbol pci_find_class > > > >Ed > > >---------- >From: Dave Grothe [mailto:[email protected]] >Sent: Thursday, February 10, 2005 10:19 AM >To: Rodrigues, Edward; [email protected] >Cc: Wm. Reich; LiS Mailing List >Subject: RE: [Linux-streams] missing symbols... > >At 08:11 AM 2/10/2005, Rodrigues, Edward wrote: >> >>Hi All, >> >>I did check 2.6.10 kernel. cdev_put() and cdev_get() are not exported. >> >>But sleep_on() and sleep_on_timeout() are still defined as well as >>exported in kernel 2.6.10 unlike RHEL4 or FC-3. >> >>Since some of these symbols are deprecated or obsoleted and hard to >>pursue these kernel folks, can we use sleep_on_interruptible() instead >>of sleep_on() in LiS. > >Does anyone actually use these functions? They are WAY outside the >STREAMS DKI. > > >>In the case of cdev_put can we stick the code in LiS >> >>void cdev_put(struct cdev *p) >>{ >> if (p) { >> kobject_put(&p->kobj); >> module_put(p->owner); >> } >>} >> >>BTW: I tried these changes with kernel 2.6.8 and worked fine for me. I >>may not be testing complete functionality -:). It did work on FC-3 as >>well. I am yet to validate RHEL 4. > >This should work just fine. Isn't it odd that they export kobject_put and >module_put but not cdev_put? Seems very irrational to me. > > >>Only other change required was (inode->i_cdev->kobj.refcount) to >>(inode->i_cdev->kobj.kref.refcount) as already pointed out by someone. >> >>Other suggestion is cleaning up all deprecated functions in LiS. This >>might save us in the longer run. >> >>Thanks >>Ed