RE: missing symbols...
dan_gora <[email protected]>
| Newsgroups | gmane.linux.kernel.streams |
|---|---|
| Message-ID | <[email protected]> |
Just to chime in as an update here. To make things work on RHEL4 x86_64 I had to remove the sleep_on() function, lis_sleep_on(), because it is in fact not exported as Edward pointed out. It's not really clear to me what this is even used for. Anyone in the LiS community going to be upset if this function goes away? (Not that you really have much choice) I know that we don't use it at all. Also, I put in Edward's trick of just inserting the body of cdev_put() in place of cdev_put and that does seem to work fine for RHEL 4.0. Another silly "feature" of RHEL 4.0 is that if you use the kbuild method to build your drivers (that is $(MAKE) -C /usr/src/linux -M `pwd` modules), RHEL 4.0 gives you -Os and -g for gcc flags by default. Ugh. This meant that I had to go around adding 'strip -d <filename>' to all my makefiles to get rid of all of the debugging crap. Just to let you know... thanks- dan > >---------- > >From: Dave Grothe [mailto:[email protected]] > >Sent: Thursday, February 10, 2005 10:19 AM > >To: Rodrigues, Edward; [email protected] > >Cc: Wm. Reich; LiS Mailing List > >Subject: RE: [Linux-streams] missing symbols... > > > >At 08:11 AM 2/10/2005, Rodrigues, Edward wrote: > >> > >>Hi All, > >> > >>I did check 2.6.10 kernel. cdev_put() and cdev_get() are not > exported. > >> > >>But sleep_on() and sleep_on_timeout() are still defined as well > as > >>exported in kernel 2.6.10 unlike RHEL4 or FC-3. > >> > >>Since some of these symbols are deprecated or obsoleted and hard > to > >>pursue these kernel folks, can we use sleep_on_interruptible() > instead > >>of sleep_on() in LiS. > > > >Does anyone actually use these functions? They are WAY outside > the > >STREAMS DKI. > > > > > >>In the case of cdev_put can we stick the code in LiS > >> > >>void cdev_put(struct cdev *p) > >>{ > >> if (p) { > >> kobject_put(&p->kobj); > >> module_put(p->owner); > >> } > >>} > >> > >>BTW: I tried these changes with kernel 2.6.8 and worked fine for > me. I > >>may not be testing complete functionality -:). It did work on > FC-3 as > >>well. I am yet to validate RHEL 4. > > > >This should work just fine. Isn't it odd that they export > kobject_put and > >module_put but not cdev_put? Seems very irrational to me.