Re: does this work?

"Brian F. G. Bidulock" <[email protected]>
Newsgroups gmane.linux.kernel.streams
Organization http://www.openss7.org/
Message-ID <[email protected]>
Jeff,

Don't know what that check is there for, but both rq and wq have been used
extensively by that point.  It is probably just cruft, but I will leave it
alone in 2.18.1.

--brian

On Thu, 21 Oct 2004, Jeff Goldszer wrote:

> 
>    I  am  in the middle of trouble shooting an issue in LiS 2.18 (more on
>    that in my next email).
> 
> 
>    Doing code inspections - I found this in lis_qdetach.
> 
> 
>           /*
> 
>         *  SVR4  STREAMS  manual  says  to ignore close routine in the wq
>    structure.
> 
>        */
> 
>       if (!LIS_CHECK_Q_MAGIC(rq) || !LIS_CHECK_Q_MAGIC(wq))
> 
>       {
> 
>           lis_unfreezestr(rq) ;
> 
>           return ;                                /* lose the memory */
> 
>       }
> 
> 
>           Why is this code unfreezing an invalid queue structure? What is
>    this supposed to do?
> 
> 
>    Jeff Goldszer
> 
>    Senior Software Engineer
> 
>    Alebra Technologies
> 
>    9915 66th Avenue
> 
>    Apartment 2C
> 
>    Rego Park, NY 11374
> 
>    Phone: 718-606-8535
> 
>    FAX:  718-606-8536

-- 
Brian F. G. Bidulock    ¦ The reasonable man adapts himself to the ¦
[email protected]    ¦ world; the unreasonable one persists in  ¦
http://www.openss7.org/ ¦ trying  to adapt the  world  to himself. ¦
                        ¦ Therefore  all  progress  depends on the ¦
                        ¦ unreasonable man. -- George Bernard Shaw ¦
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.