Re: [PATCH] remove duplicate irq instrumentation for MIPS

Hi Tim,

Thanks for the patch, I catched it in my markers port in lttng 0.6.0preX, it
should be ready soon. :)

Mathieu

* Tim Bird ([email protected]) wrote:
> This patch removes MIPS-specific irq entry and exit instrumentation.
> 
> I was getting duplicate events for each irq entry and exit
> on a MIPS machine.  I believe this was left over from before
> the use of generic interrupt handling by the MIPS arch.
> The instrumentation points in handle_IRQ_event() now seem
> to generate the appropriate events.
> 
> Instead of applying the patch, you can also just delete the
> first 2 hunks of changes in
> patch-2.6.17-lttng-0.5.113-instrumentation-mips.diff.
> 
> Regards,
>  -- Tim
> 
> diff -u -X /home/tbird/dontdiff -pruN linux.orig/arch/mips/kernel/irq.c linux/arch/mips/kernel/irq.c
> --- linux.orig/arch/mips/kernel/irq.c	2006-09-29 14:15:52.000000000 -0700
> +++ linux/arch/mips/kernel/irq.c	2006-09-29 14:13:25.000000000 -0700
> @@ -22,7 +22,6 @@
>  #include <linux/sched.h>
>  #include <linux/seq_file.h>
>  #include <linux/kallsyms.h>
> -#include <linux/ltt/ltt-facility-kernel.h>
> 
>  #include <asm/atomic.h>
>  #include <asm/system.h>
> @@ -60,12 +59,8 @@ asmlinkage unsigned int do_IRQ(unsigned
>  	irq_enter();
> 
>  	__DO_IRQ_SMTC_HOOK();
> -	trace_kernel_irq_entry(irq, !(user_mode(regs)));
> -
>  	__do_IRQ(irq, regs);
> 
> -	trace_kernel_irq_exit();
> -
>  	irq_exit();
> 
>  	return 1;
> 
> _______________________________________________
> ltt-dev mailing list
> [email protected]
> http://www.listserv.shafik.org/listserv/listinfo/ltt-dev
> 
OpenPGP public key:              http://krystal.dyndns.org:8080/key/compudj.gpg
Key fingerprint:     8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68