Re: [PATCH] Fixup armksyms to work with _printk

Oops, sorry, replied too fast.

You are right, ARM does not define this flag. We'll have to find a workaround...
tomorrow :)

Mathieu


* Johnicholas Hines ([email protected]) wrote:
> You guys are amazingly fast. and smart.
> After applying that printk -> _printk patch, I got this compile error.
> I apologize, but I don't have a patch to fix it.
> 
>  CC      kernel/fork.o
> kernel/fork.c: In function `copy_process':
> kernel/fork.c:1095: error: `TIF_SYSCALL_AUDIT' undeclared (first use
> in this function)
> kernel/fork.c:1095: error: (Each undeclared identifier is reported only once
> kernel/fork.c:1095: error: for each function it appears in.)
> 
> (cross-compiling 2.6.17.9+lttng-0.6.0 for an arm board)
> 
> Johnicholas
> 
> On 10/4/06, Mathieu Desnoyers <[email protected]> wrote:
> >* Deepak Saxena ([email protected]) wrote:
> >> On Oct 04 2006, at 13:34, Mathieu Desnoyers was caught saying:
> >> > Hi Deepak,
> >> >
> >> > You will probably want to checkout the git HEAD of v2.6.18-lttng : I am
> >> > currently fixing the last compilation errors. It should be working in a
> >few
> >> > hours.
> >>
> >
> >By the way, I am in the process of removing the _printk overriding : I will
> >simply use a __builtin_return_address(0) instead.
> >
> >>OK, I've got everything fixed except what seems to be a missing
> >> ltt_get_index_from_facility_kernel for ARM.
> >>
> >
> >in ltt-probe-arm.c ?
> >
> >it is defined in include/ltt/ltt-facility-select-kernel.h
> >
> >> One question I have from doign this...why do we need to use the AUDIT 
> >flag
> >> instaed of the jsut using the TRACE flag to mark syscall tracing for LTT?
> >>
> >
> >We cannot use the TRACE flag because it can be set to off at runtime with a
> >ptrace is detached. AUDIT seems to stay "on" once it is set. The clean way
> >to do
> >it would probably be to have our own flag.
> >
> >Mathieu
> >
> >
> >> ~Deepak
> >>
> >> --
> >> Deepak Saxena - [email protected] - http://www.plexity.net
> >>
> >> "An open heart has no possessions, only experiences" - Matt Bibbeau
> >>
> >OpenPGP public key:
> >http://krystal.dyndns.org:8080/key/compudj.gpg
> >Key fingerprint:     8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68
> >_______________________________________________
> >ltt-dev mailing list
> >[email protected]
> >http://www.listserv.shafik.org/listserv/listinfo/ltt-dev
> >
> 
OpenPGP public key:              http://krystal.dyndns.org:8080/key/compudj.gpg
Key fingerprint:     8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68