Re: [PATCH] MIPS Fixups for LTTng (Update)

Hi,

Still some comments :

* Manish Lachwani ([email protected]) wrote:
> Index: linux-2.6.18/arch/mips/kernel/scall32-o32.S
> ===================================================================
> --- linux-2.6.18.orig/arch/mips/kernel/scall32-o32.S
> +++ linux-2.6.18/arch/mips/kernel/scall32-o32.S
> @@ -69,7 +69,6 @@ stack_done:
>  #ifdef CONFIG_LTT
>  	sw  t2, PT_R1(sp)
>  	move  a0, sp
> -	jal     trace_real_syscall_entry
>  	lw  t2, PT_R1(sp)
>  
>  	lw  a0, PT_R4(sp)		# Restore argument registersa

Everything between #ifdef CONFIG_LTT and #endif // CONFIG_LTT should be
removed. The same for scall64*...


> @@ -94,10 +93,6 @@ stack_done:
>  					# restarting
>  1:	sw	v0, PT_R2(sp)		# result
>  
> -#ifdef CONFIG_LTT
> -	jal trace_real_syscall_exit
> -#endif // CONFIG_LTT
> -
>  o32_syscall_exit:
>  	raw_local_irq_disable	# make sure need_resched and
>  					# signals dont change between
> @@ -139,10 +134,6 @@ syscall_trace_entry:
>  					# restarting
>  1:	sw	v0, PT_R2(sp)		# result
>  
> -#ifdef CONFIG_LTT
> - jal trace_real_syscall_exit
> -#endif //CONFIG_LTT)
> -
>  	j	syscall_exit
>  
>  /* ------------------------------------------------------------------------ */

Mathieu

OpenPGP public key:              http://krystal.dyndns.org:8080/key/compudj.gpg
Key fingerprint:     8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68