Re: What's become with PPC patches?

Hello.

Mathieu Desnoyers wrote:
>>>* Mathieu Desnoyers ([email protected]) wrote:

>>>>Note that there should also be a call to trace_kernel_trap_entry/exit in
>>>>probe_mm_handle_fault_entry/exit in ltt/probes/ltt-probe-ppc.c (see
>>>>ltt-probe-i386.c for an example). I will fix in the next releases.

>>>Fixed in LTTng 0.6.25, please test.

>>   Given the fact that __handle_mm_fault() is called not only from the arch 
>>fault handlers but also from get_user_pages(), this fix doesn't look 
>>correct to me.

> I plan to use the following workaround :

> in
> void probe_mm_handle_fault_entry(const char *format, ...)

>         /* Call tracer */
>         if(in_irq())
>                 trace_kernel_trap_entry(trap_id, (void*)eip);

    What do traps have in common with irqs?!
    Answer: not *that* much.

>         trace_memory_page_fault(address, eip);
> 
> and
> void probe_mm_handle_fault_exit(const char *format, ...)
> 
> 
>         /* Call tracer */
>         if(in_irq())
>                 trace_kernel_trap_exit();

> This fix is correct as long as get_user_pages in never called from an
> interrupt context.

    Not correct at all, IMO.

> Mathieu

WBR, Sergei