Re: [PATCH] marker fixup for ltt-probe-*

Mathieu Desnoyers wrote:
> Hi,
> 
> * Kevin Hilman ([email protected]) wrote:
>> Fix up some markers in ltt-probe-* that were found when trying to load
>> them as modules and getting -EPERM. Some are #ifdef XYZ in the kernel
>> code but not in the , and others appear to be typos.
>>
>> Patch is against today's git tree.
>>
>> -       result = marker_set_probe("kernel_timer_update_time",
>> -                       KERNEL_TIMER_UPDATE_TIME_FORMAT,
>> -                       probe_kernel_timer_update_time);
>> -       if (!result)
>> -               goto cleanup;
>> +       /* TODO: this is marked as TODO in kernel/timer.c */
>> +/*     result = marker_set_probe("kernel_timer_update_time", */
>> +/*                     KERNEL_TIMER_UPDATE_TIME_FORMAT, */
>> +/*                     probe_kernel_timer_update_time); */
>> +/*     if (!result) */
>> +/*             goto cleanup; */
>>
> 
> I don't see any TODO in kernel/timer.c for the marker, should I apply this
> one ?
> 

Maybe because I was working from an earlier release.  Looks like the
MARK is avaialble in the git tree but has moved to do_timer() so that
marker_set_probe("kernel_timer_update_timer"...) could be uncommented.

Thanks,

Kevin