Re: What's become with PPC patches?

Sergei Shtylyov <[email protected]>
Newsgroups gmane.linux.kernel.tracing
Organization MontaVista Software Inc.
Message-ID <[email protected]>
Hello.

Mathieu Desnoyers wrote:

> You are right, I see no other place to put the trap entry/exit elsewhere than in
> arch/*/mm/fault.c. I will leave the new "page_fault" event, which is linked to
> the handle_mm_fault function : it makes sense to instrument page faults caused
> by get_user_pages too.

    That fix caused warning to be emitted:

arch/powerpc/mm/fault.c: In function ‘do_page_fault’:
arch/powerpc/mm/fault.c:347: warning: format ‘%d’ expects type ‘int’, but 
argument 2 has type ‘long unsigned int’

    That's poses danger on PPC64 where sizeof(int) == 4 and sizeof(long) == 8.

WBR, Sergei
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.