Re: [RFC] atomic_up operations

Hello.

Mathieu Desnoyers wrote:

> LTTng 0.6.28-29 introduces asm-*/atomic-up.h which has atomic operations without
> LOCK prefix event on SMP. This is for atomic access of per-cpu data.

    include/asm-powerpc/atomic-up.h contains Unicode chars in the most 
unpleasant place:

include/asm/atomic-up.h:8:27: error: asm/atomicéh: No such file or directory
In file included from ltt/ltt-relay.c:49:
include/asm/atomic-up.h:18: error: redefinition of ‘atomic_up_add’
include/asm/atomic.h:241: error: previous definition of ‘atomic_up_add’ was 
hereinclude/asm/atomic-up.h:33: error: redefinition of ‘atomic_up_add_return’
include/asm/atomic.h:256: error: previous definition of ‘atomic_up_add_return’ 
was here
include/asm/atomic-up.h:52: error: redefinition of ‘atomic_up_sub’
include/asm/atomic.h:275: error: previous definition of ‘atomic_up_sub’ was 
hereinclude/asm/atomic-up.h:67: error: redefinition of ‘atomic_up_sub_return’
include/asm/atomic.h:290: error: previous definition of ‘atomic_up_sub_return’ 
was here
include/asm/atomic-up.h:84: error: redefinition of ‘atomic_up_inc’
include/asm/atomic.h:307: error: previous definition of ‘atomic_up_inc’ was 
hereinclude/asm/atomic-up.h:99: error: redefinition of ‘atomic_up_inc_return’
include/asm/atomic.h:322: error: previous definition of ‘atomic_up_inc_return’ 
was here
include/asm/atomic-up.h:126: error: redefinition of ‘atomic_up_dec’
include/asm/atomic.h:349: error: previous definition of ‘atomic_up_dec’ was 
hereinclude/asm/atomic-up.h:141: error: redefinition of ‘atomic_up_dec_return’
include/asm/atomic.h:364: error: previous definition of ‘atomic_up_dec_return’ 
was here
include/asm/atomic-up.h:170: error: redefinition of ‘atomic_up_add_unless’
include/asm/atomic.h:393: error: previous definition of ‘atomic_up_add_unless’ 
was here
include/asm/atomic-up.h:200: error: redefinition of ‘atomic_up_dec_if_positive’
include/asm/atomic.h:423: error: previous definition of 
‘atomic_up_dec_if_positive’ was here

WBR, Sergei