Re: [PATCH 3/16] LTTng 0.6.36 for 2.6.18 : Linux Kernel Markers

[email protected] (Frank Ch. Eigler) 27 Nov 2006 21:23:17 -0500

Newsgroups	gmane.linux.systemtap,gmane.linux.kernel,gmane.linux.kernel.tracing
Message-ID	<[email protected]>

Mathieu Desnoyers <[email protected]> writes:

> This patch adds the Linux Kernel Markers [...]
> Signed-off-by : Mathieu Desnoyers <[email protected]>

If it helps,
Acked-by: Frank Ch. Eigler <[email protected]>

One question:

> [...]
> +	/* Markers in modules. */ 
> +	list_for_each_entry(mod, &modules, list) {
> +		if (mod->license_gplok)
> +			found += marker_set_probe_range(name, format, probe,
> +				mod->markers, mod->markers+mod->num_markers);
> +	}
> [...]
> +EXPORT_SYMBOL(marker_set_probe);

Are you sure the license_gplok check is necessary here?  We should
consider encouraging non-gpl module writers to instrument their code,
to give users a slightly better chance of debugging problems.

- FChE