Re: [PATCH] Relay CPU hotplug support

Hi Tom,

Yes, it looks ok. I see that you chose to make global channels use the cpu
hotplug callback to set the buffer to buf[0], which is a reasonable choice
considering that is_global is not available as a parameter to relay_open.

I agree that passing flags to relay_open should come in a second time : it will
allow to :

- Not take a cpu hotplug lock when dealing with global channels
- Preset buffer pointers for each possible cpu to buf[0] so the hotplug handler
  would have nothing to do for those channels. I would prefer to keep a complete
  list of both global and non global channels (it might be useful for other
  purposes). It would imply to add a test if(chan->is_global) to simply unlock
  the list and return in the cpu hotplug handler.

Thanks,

Mathieu

* Tom Zanussi ([email protected]) wrote:
> Hi Mathieu,
> 
> Here's the current patch, with the additional patches you sent and
> forwarded applied.  I also added documentation for the private_data
> API change, a fix for a problem with the base_filename that I noticed,
> a fix in CPU_UP_PREPARE to check if there's already a buffer before
> creating one, and some small cleanups.  I didn't do anything about the
> flags param - that should probably be a separate patch anyway.
> 
> Tom
> 
OpenPGP public key:              http://krystal.dyndns.org:8080/key/compudj.gpg
Key fingerprint:     8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68