Re: KConfig issues

Hi Deepak,

Thanks for reporting. Please try the following fix (will be in 0.6.46).

Mathieu

diff --git a/Makefile b/Makefile
index eb9b597..06df13d 100644
--- a/Makefile
+++ b/Makefile
@@ -1,7 +1,7 @@
 VERSION = 2
 PATCHLEVEL = 6
 SUBLEVEL = 19
-EXTRAVERSION =-lttng-0.6.45
+EXTRAVERSION =-lttng-0.6.46
 NAME=Avast! A bilge rat!
 
 # *DOCUMENTATION*
diff --git a/ltt/Kconfig b/ltt/Kconfig
index c80b904..c5023d1 100644
--- a/ltt/Kconfig
+++ b/ltt/Kconfig
@@ -107,7 +107,7 @@ config LTT_SYNTHETIC_TSC
 
 config LTT_USERSPACE_GENERIC
 	bool "Allow tracing from userspace"
-	depends on LTT_TRACER
+	depends on LTT
 	default y
 	help
 	  This options allows processes to trace through the ltt_trace_generic
@@ -125,7 +125,6 @@ config LTT_NETLINK_CONTROL
 config LTT_STATEDUMP
 	tristate "Linux Trace Toolkit State Dump"
 	depends on LTT_TRACER
-	select LTT_PROBES
 	select LTT_PROBE_LIST
 	default m
 	help
@@ -137,90 +136,105 @@ config LTT_STATEDUMP
 
 menu "Probes"
 	depends on LTT
-
-config LTT_PROBES
-	bool "Activate LTT probes"
-	depends on LTT_TRACER
-	select MARKERS
-	default y
-	help
-	  Activate per facilities LTT probes. This is the dynamic mechanism
-	  where the data gathering is. Probes connect to markers when their
-	  module is loaded.
+	depends on MARKERS
 
 config LTT_PROBE_FS
 	tristate "Linux Trace Toolkit File System Probe"
-	depends on LTT_PROBES
 	select LTT_FACILITY_FS
 	select LTT_FACILITY_FS_DATA
 	default m
 	help
+	  Activate per facilities LTT probes. This is the dynamic mechanism
+	  where the data gathering is. Probes connect to markers when their
+	  module is loaded.
+
 	  Probe file system events.
 
 config LTT_PROBE_IPC
 	tristate "Linux Trace Toolkit Inter-Process Communication Probe"
-	depends on LTT_PROBES
 	select LTT_FACILITY_IPC
 	default m
 	help
+	  Activate per facilities LTT probes. This is the dynamic mechanism
+	  where the data gathering is. Probes connect to markers when their
+	  module is loaded.
+
 	  LTT IPC probe.
 
 config LTT_PROBE_KERNEL
 	tristate "Linux Trace Toolkit Kernel Probe"
-	depends on LTT_PROBES
 	select LTT_FACILITY_KERNEL
 	select LTT_FACILITY_PROCESS
 	select LTT_FACILITY_TIMER
 	default m
 	help
+	  Activate per facilities LTT probes. This is the dynamic mechanism
+	  where the data gathering is. Probes connect to markers when their
+	  module is loaded.
+
 	  LTT Kernel facility.
 
 config LTT_PROBE_ARCH
 	tristate "Linux Trace Toolkit Architecture Specific Probe"
-	depends on LTT_PROBES
 	select LTT_FACILITY_KERNEL
 	select LTT_FACILITY_KERNEL_ARCH
 	select LTT_FACILITY_IPC
 	select LTT_FACILITY_MEMORY
 	default m
 	help
+	  Activate per facilities LTT probes. This is the dynamic mechanism
+	  where the data gathering is. Probes connect to markers when their
+	  module is loaded.
+
 	  LTT Arch Probe.
 
 config LTT_PROBE_MM
 	tristate "Linux Trace Toolkit Memory Probe"
-	depends on LTT_PROBES
 	select LTT_FACILITY_MEMORY
 	default m
 	help
+	  Activate per facilities LTT probes. This is the dynamic mechanism
+	  where the data gathering is. Probes connect to markers when their
+	  module is loaded.
+
 	  LTT Memory probe.
 
 config LTT_PROBE_NET
 	tristate "Linux Trace Toolkit Network Probe"
-	depends on LTT_PROBES
 	select LTT_FACILITY_NETWORK
 	select LTT_FACILITY_SOCKET
 	select LTT_FACILITY_NETWORK_IP_INTERFACE
 	default m
 	help
+	  Activate per facilities LTT probes. This is the dynamic mechanism
+	  where the data gathering is. Probes connect to markers when their
+	  module is loaded.
+
 	  LTT Network probe.
 
 config LTT_PROBE_LIST
 	tristate "Linux Trace Toolkit system listing probe"
-	depends on LTT_PROBES
 	select LTT_FACILITY_STATEDUMP
 	default m
 	help
+	  Activate per facilities LTT probes. This is the dynamic mechanism
+	  where the data gathering is. Probes connect to markers when their
+	  module is loaded.
+
 	  System listing probe.
 
 config LTT_PROBE_LOCKING
 	tristate "Linux Trace Toolkit locking"
-	depends on LTT_PROBES
 	select TRACE_IRQFLAGS
 	select LOCKDEP
 	select DEBUG_LOCK_ALLOC
 	select LTT_FACILITY_LOCKING
 	default m
 	help
+	  Activate per facilities LTT probes. This is the dynamic mechanism
+	  where the data gathering is. Probes connect to markers when their
+	  module is loaded.
+
 	  System listing probe.
 
 endmenu
diff --git a/ltt/Makefile b/ltt/Makefile
index ff7aa5f..4baa2aa 100644
--- a/ltt/Makefile
+++ b/ltt/Makefile
@@ -12,4 +12,4 @@ obj-$(CONFIG_LTT_STATEDUMP)		+= ltt-stat
 obj-$(CONFIG_LTT_FACILITY_STACK)	+= ltt-stack.o
 
 obj-$(CONFIG_LTT)			+= facilities/
-obj-$(CONFIG_LTT_PROBES)		+= probes/
+obj-$(CONFIG_LTT)			+= probes/



* Deepak Saxena ([email protected]) wrote:
> 
> I'm working on some scripts to automate building and testing of
> lttng and running into some issues with my config setting sticking.
> Basically, I run menuconfig and configure every LTTng component that
> can be modularized to be so:
> 
> CONFIG_MARKERS=y
> CONFIG_LTT=y
> CONFIG_LTT_TRACER=m
> CONFIG_LTT_RELAY=m
> CONFIG_LTT_ALIGNMENT=y
> # CONFIG_LTT_HEARTBEAT is not set
> CONFIG_LTT_USERSPACE_GENERIC=y
> CONFIG_LTT_NETLINK_CONTROL=m
> CONFIG_LTT_STATEDUMP=m
> CONFIG_LTT_PROBES=y
> CONFIG_LTT_PROBE_FS=m
> CONFIG_LTT_PROBE_IPC=m
> CONFIG_LTT_PROBE_KERNEL=m
> CONFIG_LTT_PROBE_ARCH=m
> CONFIG_LTT_PROBE_MM=m
> CONFIG_LTT_PROBE_NET=m
> CONFIG_LTT_PROBE_LIST=m
> CONFIG_LTT_FACILITY_FS=m
> CONFIG_LTT_FACILITY_FS_DATA=m
> CONFIG_LTT_FACILITY_IPC=m
> CONFIG_LTT_FACILITY_KERNEL=m
> CONFIG_LTT_FACILITY_KERNEL_ARCH=m
> CONFIG_LTT_FACILITY_MEMORY=m
> CONFIG_LTT_FACILITY_NETWORK=m
> CONFIG_LTT_FACILITY_NETWORK_IP_INTERFACE=m
> CONFIG_LTT_FACILITY_PROCESS=m
> CONFIG_LTT_FACILITY_SOCKET=m
> CONFIG_LTT_FACILITY_STATEDUMP=m
> CONFIG_LTT_FACILITY_TIMER=m
> 
> I can vi the .config and see that this is how everything is set. Now,
> if I run menuconfig and go down to LTT, these settings change w/o me
> touching them, and the same happens if I run make oldconfig:
> 
> --- .config     2006-12-15 10:27:35.000000000 -0800
> +++ config-old       2006-12-15 10:25:55.000000000 -0800
> @@ -1035,13 +1035,13 @@
>  CONFIG_MARKERS=y
>  CONFIG_LTT=y
> -CONFIG_LTT_TRACER=y
> +CONFIG_LTT_TRACER=m
>  CONFIG_LTT_RELAY=m
>  CONFIG_LTT_ALIGNMENT=y
>  # CONFIG_LTT_HEARTBEAT is not set
>  CONFIG_LTT_USERSPACE_GENERIC=y
>  CONFIG_LTT_NETLINK_CONTROL=m
> -CONFIG_LTT_STATEDUMP=y
> +CONFIG_LTT_STATEDUMP=m
> 
>  #
>  # Probes
> @@ -1053,7 +1053,7 @@
>  CONFIG_LTT_PROBE_ARCH=m
>  CONFIG_LTT_PROBE_MM=m
>  CONFIG_LTT_PROBE_NET=m
> -CONFIG_LTT_PROBE_LIST=y
> +CONFIG_LTT_PROBE_LIST=m
> 
>  #
>  # Event types
> @@ -1068,7 +1068,7 @@
>  CONFIG_LTT_FACILITY_NETWORK_IP_INTERFACE=m
>  CONFIG_LTT_FACILITY_PROCESS=m
>  CONFIG_LTT_FACILITY_SOCKET=m
> -CONFIG_LTT_FACILITY_STATEDUMP=y
> +CONFIG_LTT_FACILITY_STATEDUMP=m
>  CONFIG_LTT_FACILITY_TIMER=m
> 
> 
> I've looked at ltt/kconfig and I can't see what dependency would cause this
> to happen and also tried to change the defaults for ltt_tracer to m but
> that doesn't seem to solve the problem.
> 
> Mathieu, is there some depedency I'm not seeing that I need to force to
> 'm' for the above LTT options to be modularized?
> 
> Tnx,
> ~Deepak
> 
> -- 
> Deepak Saxena - [email protected] - http://www.plexity.net
> 
> The terrorist and the policeman both come from the same basket.
> 	-- Joseph Conrad, The Secret Agent 
> _______________________________________________
> Ltt-dev mailing list
> [email protected]
> http://listserv.shafik.org/mailman/listinfo/ltt-dev
> 
OpenPGP public key:              http://krystal.dyndns.org:8080/key/compudj.gpg
Key fingerprint:     8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68