Re: [PATCH 05/05] Linux Kernel Markers, non optimised architectures
Mathieu Desnoyers <[email protected]>
| Newsgroups | gmane.linux.kernel.tracing,gmane.linux.kernel,gmane.linux.systemtap |
|---|---|
| Message-ID | <20070112174312.GA22771@Krystal> |
* Mathieu Desnoyers ([email protected]) wrote: > > > > OK, well one problem is that it can cause a resched event to be lost, so > > you might say it has more side-effects without checking resched. > > [...] > If we are sure that we expect calls to preempt_schedule() from each of these > contexts, then it's ok to put preempt_enable(). It is important to note that a > marker would then act as a source of scheduler events in code paths where > disabling interrupts is expected to disable the scheduler. > Sorry for self-reply, but the above mentioned issue is dealt by the irqs_disabled() check at the beginning of preempt_schedule(). Mathieu -- OpenPGP public key: http://krystal.dyndns.org:8080/key/compudj.gpg Key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68