Re: [RFC] New markers description without format strings
"Frank Ch. Eigler" <[email protected]>
| Newsgroups | gmane.linux.kernel.tracing |
|---|---|
| Message-ID | <[email protected]> |
Hi - On Mon, May 07, 2007 at 10:02:24AM -0400, Mathieu Desnoyers wrote: > I'll skip the implementation details, but I am considering changing the > current marker implementation, which uses format strings, for something > that would look like : > > trace_mark(subsysname, eventname, mark_types(MARK_CHAR, MARK_ULLONG), > mychar, myull); Clever, but it is starting to look too wordy, and if I squint just enough, it looks close to the old "decorate the function name with the parameter types" technique. > [...] Moreover, this should be more efficient to do a switch() on > the enum members than to parse the format string. FWIW, systemtap would not need to parse either the string or the type tag array at run time (but rather at translate time), so the performance difference does not affect it. - FChE