Re: [RFC] New markers description without format strings
Christoph Hellwig <[email protected]>
| Newsgroups | gmane.linux.kernel.tracing |
|---|---|
| Message-ID | <[email protected]> |
On Tue, May 08, 2007 at 11:30:14AM -0400, Mathieu Desnoyers wrote: > Since I don't need to express anything else than the types expected > (unlike printf, no text is required), the function that marshalls the > variable arguments could be implemented more efficiently using a switch > on a type enumeration rather that parsing the format string (which I > currently do : it's inspired from vsnprintf). > > Since I have to extend the standard format strings with new types > (telling explicitly how to expect a 32 or 64 bits integer in a portable > manner in architecture independant code, or how to serialize an array, or > a struct), I currently added the following tweaks to the format strings > expected by the markers. That's probably a good argument, especially if we could actually do some typechecking on the arguments to reject probes on mismatching markers. Then again I really like format strings for some reason..