Re: [PATCH 2/3] Always check marker consitency

[email protected] (Frank Ch. Eigler) 15 May 2007 15:21:08 -0400

Newsgroups	gmane.linux.kernel.tracing
Message-ID	<[email protected]>

Hi -

> >  		if (flags & MF_LOCKDEP
> >  			&& !(iter->mdata->flags & MF_LOCKDEP)) {
> >  			printk(KERN_NOTICE

Regarding these marker flags, could we make do without this additional
hard-coded numerical ABI?  How about adding such annotations right
into the formatting string, for example:

     mark(subsystem_ticklish, "ticklish %p %p", var1, var2);

The presence of the "ticklish" string would be taken to require the
marker client to abstain from any activity that may tickle the
subsystem.  The lockdep/don't-you-dare-printk flags could appear as
similar strings.

- FChE