Re: lttng-instrumentation-sh.patch issue

* Giuseppe Cavallaro ([email protected]) wrote:
> Applying the lttng-instrumentation-sh.patch there is a duplicated call
> of do_fork function in SH arch code (see below).
> ------------------------------------------------------------------------
> 
> int kernel_thread(int (*fn)(void *), void * arg, unsigned long flags)
> {
>         unsigned long pid;
>         struct pt_regs regs;
> 
>         memset(&regs, 0, sizeof(regs));
>         regs.regs[4] = (unsigned long)arg;
>         regs.regs[5] = (unsigned long)fn;
> 
>         regs.pc = (unsigned long)kernel_thread_helper;
>         regs.sr = (1 << 30);
> 
>         /* Ok, create the new process.. */
>         return do_fork(flags | CLONE_VM | CLONE_UNTRACED, 0,   <<<<<
> These two lines have to be removed
>                        &regs, 0, NULL, NULL);                  <<<<<
> (as i386 does for example).
>         pid =  do_fork(flags | CLONE_VM | CLONE_UNTRACED, 0,
>                        &regs, 0, NULL, NULL);
>         trace_mark(kernel_arch_kthread_create, "pid %ld fn %p", pid, fn);
>         return pid;
> }
> ------------------------------------------------------------------------
> 
Fixed in pre34. Thanks!

> Regards,
>  Giuseppe

> _______________________________________________
> Ltt-dev mailing list
> [email protected]
> http://listserv.shafik.org/mailman/listinfo/ltt-dev


-- 
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68