Re: [PATCH][LTTV] take account of the byte order when reading event ids

Jan Altenberg <[email protected]> Wed, 05 Dec 2007 14:35:33 +0100
Newsgroups gmane.linux.kernel.tracing,gmane.linux.kernel.tracing.viewer
Message-ID <[email protected]>
Dammit - Adjusted the CC line...This time using the correct address for
lttv-dev ;-)

> Hi all,
> 
> I tried to view a trace, which has been captured on a powerpc target, on
> my x86 based host and ran into some trouble (lttv was parsing wrong
> event IDs). I'm using lttv-0.10.0-pre4-28112007. The trace was captured
> with 2.6.24-rc3-git1-lttng-0.10-pre3 on a MPC8548CDS.
> 
> Attached patch fixes things for me.
> 
> Cheers,
> 	Jan

Index: lttv-0.10.0-pre4-28112007/ltt/tracefile.c
===================================================================
--- lttv-0.10.0-pre4-28112007.orig/ltt/tracefile.c
+++ lttv-0.10.0-pre4-28112007/ltt/tracefile.c
@@ -1868,7 +1868,7 @@ int ltt_tracefile_read_update_event(LttT
   event->event_time = ltt_interpolate_time(tf, event);
 
   if(!tf->compact) {
-    event->event_id = *(guint16*)pos;
+    event->event_id = ltt_get_uint16(LTT_GET_BO(tf), pos);
     pos += sizeof(guint16);
 
     event->event_size = ltt_get_uint16(LTT_GET_BO(tf), pos);