Re: [PATCH] Trivial fix for lttvwindowtraces.c

Mathieu Desnoyers <[email protected]> Mon, 10 Mar 2008 21:39:09 -0400
Newsgroups gmane.linux.kernel.tracing
Message-ID <20080311013909.GA1403@Krystal>
* Jan Altenberg ([email protected]) wrote:
> Hi,
> 
> this patch fixes two uninitialized usages of 'result'. Applies on top of
> lttv-0.10.0-pre10-18012008.
>

It is merged in lttv-0.10.0-pre11, thanks!

Mathieu

> Cheers,
> 	Jan
> 
> Index: lttv-0.10.0-pre10-18012008/lttv/modules/gui/lttvwindow/lttvwindow/lttvwindowtraces.c
> ===================================================================
> --- lttv-0.10.0-pre10-18012008.orig/lttv/modules/gui/lttvwindow/lttvwindow/lttvwindowtraces.c
> +++ lttv-0.10.0-pre10-18012008/lttv/modules/gui/lttvwindow/lttvwindow/lttvwindowtraces.c
> @@ -344,7 +344,7 @@ __EXPORT void lttvwindowtraces_backgroun
>    GSList **slist;
>    gboolean result;
>  
> -  lttv_iattribute_find(LTTV_IATTRIBUTE(attribute),
> +  result = lttv_iattribute_find(LTTV_IATTRIBUTE(attribute),
>                                  LTTV_REQUESTS_QUEUE,
>                                  LTTV_POINTER,
>                                  &value);
> @@ -426,7 +426,7 @@ void lttvwindowtraces_background_request
>    GSList **slist;
>    gboolean result;
>  
> -  lttv_iattribute_find(LTTV_IATTRIBUTE(attribute),
> +  result = lttv_iattribute_find(LTTV_IATTRIBUTE(attribute),
>                                  LTTV_REQUESTS_QUEUE,
>                                  LTTV_POINTER,
>                                  &value);
> 
> 

-- 
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68