Re: [PATCH v1 2/6] serial: txx9: Drop usage of uart_match_port()

Ilpo Järvinen <[email protected]>
Newsgroups gmane.linux.serial,gmane.linux.kernel
Message-ID <[email protected]>
On Fri, 31 Jul 2026, Uwe Kleine-König wrote:

> In this driver .iotype is always UPIO_PORT. So uart_match_port() is
> equivalent to comparing .iobase. Remove the call to uart_match_port()
> which then only has a single caller that is handled in the next commit.

Not directly related to the change. The txx9 driver seems to have some 
iotype switch/cases as well so some !UPIO_PORT deadcode too.

-- 
 i.

> Signed-off-by: Uwe Kleine-König <[email protected]>
> ---
>  drivers/tty/serial/serial_txx9.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/serial_txx9.c b/drivers/tty/serial/serial_txx9.c
> index 5ed20129b44b..2368081c3742 100644
> --- a/drivers/tty/serial/serial_txx9.c
> +++ b/drivers/tty/serial/serial_txx9.c
> @@ -965,7 +965,7 @@ static int serial_txx9_register_port(struct uart_port *port)
>  	mutex_lock(&serial_txx9_mutex);
>  	for (i = 0; i < UART_NR; i++) {
>  		uart = &serial_txx9_ports[i];
> -		if (uart_match_port(uart, port)) {
> +		if (uart->iobase == port->iobase)
>  			uart_remove_one_port(&serial_txx9_reg, uart);
>  			break;
>  		}
>
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.