Re: [PATCH v1 2/6] serial: txx9: Drop usage of uart_match_port()

Uwe Kleine-König <[email protected]> Mon, 3 Aug 2026 20:57:24 +0200

Newsgroups	gmane.linux.kernel,gmane.linux.serial
Message-ID	<anDhTEbbTgEVeSsr@monoceros>

On Mon, Aug 03, 2026 at 04:46:14PM +0200, Greg Kroah-Hartman wrote:
> On Fri, Jul 31, 2026 at 11:39:05AM +0200, Uwe Kleine-König wrote:
> > In this driver .iotype is always UPIO_PORT. So uart_match_port() is
> > equivalent to comparing .iobase. Remove the call to uart_match_port()
> > which then only has a single caller that is handled in the next commit.
> > 
> > Signed-off-by: Uwe Kleine-König <[email protected]>
> > ---
> >  drivers/tty/serial/serial_txx9.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/tty/serial/serial_txx9.c b/drivers/tty/serial/serial_txx9.c
> > index 5ed20129b44b..2368081c3742 100644
> > --- a/drivers/tty/serial/serial_txx9.c
> > +++ b/drivers/tty/serial/serial_txx9.c
> > @@ -965,7 +965,7 @@ static int serial_txx9_register_port(struct uart_port *port)
> >  	mutex_lock(&serial_txx9_mutex);
> >  	for (i = 0; i < UART_NR; i++) {
> >  		uart = &serial_txx9_ports[i];
> > -		if (uart_match_port(uart, port)) {
> > +		if (uart->iobase == port->iobase)
> >  			uart_remove_one_port(&serial_txx9_reg, uart);
> >  			break;
> >  		}
> 
> Does this even build?

Sigh, it passed my build scripts (which is essentially allmodconfig for
arc, sh, alpha, arm64, x86_64, s390, riscv, mips, powerpc, loongarch,
sparc, m68k and parisc), but this driver is only compiled for certain
mips configs and not allmodconfig :-(

Will respin with a better suitable test build.

Best regards
Uwe

signature.asc (application/pgp-signature, 488 B)