Re: [PATCH v2 4/7] mm/khugepaged: fix outdated comments

Nico Pache <[email protected]> Mon, 3 Aug 2026 13:14:09 -0600

Newsgroups	gmane.linux.kernel,gmane.linux.documentation,gmane.linux.kernel.mm
Message-ID	<CAA1CXcAsh4hOSsNbAM8MKcg1k2q_XZ3kxqiE6TpWddrSbj_soA@mail.gmail.com>

On Wed, Jul 29, 2026 at 3:45 AM David Hildenbrand (Arm)
<[email protected]> wrote:
>
>
> >        * UFFDIO_MOVE is prevented to race as well thanks to the
> >        * mmap_lock.
> > @@ -1643,7 +1643,8 @@ static enum scan_result collapse_scan_pmd(struct mm_struct *mm,
> >
> >       /*
> >        * If PMD is the only enabled order, enforce max_ptes_none, otherwise
> > -      * scan all pages to populate the bitmap for mTHP collapse.
> > +      * scan all pages to populate the bitmap for mTHP collapse. The bitmap
> > +      * is then checked again in mthp_collapse() for each attempted order.
>
> Why use () here but not in the other cases above? (e.g., collapse_scan_pmd)

Ack, I'll update that! Thanks

>
> --
> Cheers,
>
> David
>