Re: [PATCH v2 RESEND] HID: appletb-kbd: add option to switch default layer on double pressing fn key

Sent with Proton Mail secure email.

On Tuesday, 4 August 2026 at 12:32 PM, Aditya Garg <[email protected]> wrote:

> 
> 
> 
> 
> Sent with Proton Mail secure email.
> 
> On Monday, 3 August 2026 at 11:07 PM, Jiri Kosina <[email protected]> wrote:
> 
> > On Sat, 20 Jun 2026, Aditya Garg wrote:
> >
> > > From: Aditya Garg <[email protected]>
> > >
> > > This patch enables a user to switch the default layer from media to fn
> > > keys and vice-versa upon double pressing the fn key. This behaviour can
> > > be configured using the double_press_switch_time module parameter whose
> > > value depicts the time in milliseconds within which the fn key must be
> > > pressed again to switch the default layer. If set to 0, it simply
> > > disables this behaviour.
> >
> > I know that historically the apple driver had all this kind of tuning as
> > kernel module parameters, but wouldn't it make more sense to start using
> > sysfs attributes for these?
> 
> Having sysfs attributes for some, and module parameters for other tweaks seems more confusing to be tbh.

Also, please review the latest version: https://lore.kernel.org/all/[email protected]/