Re: [PATCH v2] staging: rtl8723bs: remove unnecessary parentheses from return
Greg KH <[email protected]>
| Newsgroups | gmane.linux.kernel |
|---|---|
| Message-ID | <2026080414-concept-abrasive-364a@gregkh> |
On Mon, Aug 03, 2026 at 06:06:04PM +0000, Ashmit Kumar wrote: > The Linux kernel coding style specifies that return is not a function > and therefore parentheses are not required. Ok, but: > Signed-off-by: Ashmit Kumar <[email protected]> > --- > drivers/staging/axis-fifo/axis-fifo.c | 2 +- > drivers/staging/rtl8723bs/os_dep/os_intfs.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c > index 3aa2aa870ea..ed09be2fed4 100644 > --- a/drivers/staging/axis-fifo/axis-fifo.c > +++ b/drivers/staging/axis-fifo/axis-fifo.c > @@ -246,7 +246,7 @@ static ssize_t axis_fifo_write(struct file *f, const char __user *buf, > mutex_lock(&fifo->write_lock); > > ret = wait_event_interruptible(fifo->write_queue, > - ioread32(fifo->base_addr + XLLF_TDFV_OFFSET) >= words_to_write); > + ioread32(fifo->base_addr + XLLF_TDFV_OFFSET) >= words_to_write); That's not what you did here :(