Re: [PATCH v2 2/2] arm64: dts: broadcom: bcm2712-d-rpi-5-b: add compatible

Krzysztof Kozlowski <[email protected]>
Newsgroups gmane.linux.kernel,gmane.linux.drivers.devicetree,gmane.linux.kernel.rpi,gmane.linux.ports.arm.kernel
Message-ID <20260804-unbeatable-fluffy-galago-bfe282@quoll>
On Mon, Aug 03, 2026 at 02:09:25PM +0200, Gregor Herburger wrote:
> The bcm2712 found on the Raspberry Pi 5 is available in the d Stepping
> and in a c Stepping. There are two separate dts files. The
> bcm2712-rpi-5-b.dts for the c Stepping and the bcm2712-d-rpi-5-b.dts for
> the d Stepping. The d stepping does not set its own compatible/model
> string but uses "raspberrypi,5-model-b".
> 
> These two steppings are not compatible. Booting with the wrong dtb file

Not compatible but...

> causes a crash at boot.
> 
> Add a compatibles string "raspberrypi,5-model-b-d0" to allow us to
> distinguish between those two steppings.
> 
> Signed-off-by: Gregor Herburger <[email protected]>
> ---
>  arch/arm64/boot/dts/broadcom/bcm2712-d-rpi-5-b.dts | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/broadcom/bcm2712-d-rpi-5-b.dts b/arch/arm64/boot/dts/broadcom/bcm2712-d-rpi-5-b.dts
> index 127be0fc27c2..11a38cd53401 100644
> --- a/arch/arm64/boot/dts/broadcom/bcm2712-d-rpi-5-b.dts
> +++ b/arch/arm64/boot/dts/broadcom/bcm2712-d-rpi-5-b.dts
> @@ -3,6 +3,11 @@
>  
>  #include "bcm2712-rpi-5-b.dts"
>  
> +/ {
> +	compatible = "raspberrypi,5-model-b-d0", "raspberrypi,5-model-b", "brcm,bcm2712";

this tells they are compatible. If compatibility was wrong since the
beginning, you do not have to preserve the ABI.

Best regards,
Krzysztof
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.