Re: [PATCH 3/4] arm64: dts: qcom: sm8250-xiaomi-elish: label the WiFi node
Krzysztof Kozlowski <[email protected]>
| Newsgroups | gmane.linux.drivers.devicetree,gmane.comp.video.dri.devel,gmane.linux.kernel,gmane.linux.ports.arm.msm |
|---|---|
| Message-ID | <20260804-glossy-mastodon-from-sirius-db9aac@quoll> |
On Thu, Jul 30, 2026 at 11:52:02PM +0200, Dawid Wróbel wrote: > The Mi Pad 5 Pro 5G shares this device tree but needs its own board data > variant, so give the node a label to allow overriding the property. > > Signed-off-by: Dawid Wróbel <[email protected]> > --- > arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi > index 19aff83ecf7b..12a2ba48340f 100644 > --- a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi > @@ -817,7 +817,7 @@ &pcie0_phy { > }; > > &pcieport0 { > - wifi@0 { > + wifi_0: wifi@0 { This is pointless on its own. Label does not end up in DTB, so your patch has zero effect. You miss the user of the label here. Best regards, Krzysztof