Re: [PATCH] Add JEDEC ID table entries for additional ISSI SPI-NOR devices. Additionally added several structs to support ISSI octal flash functionality. (Octal SPI 2026 revised)
kernel test robot <[email protected]>
| Newsgroups | gmane.linux.kernel,gmane.linux.drivers.mtd |
|---|---|
| Message-ID | <[email protected]> |
Hi Jeffrey, kernel test robot noticed the following build warnings: [auto build test WARNING on mtd/spi-nor/next] [also build test WARNING on linus/master v7.2-rc6 next-20260803] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Jeffrey-Yu/Add-JEDEC-ID-table-entries-for-additional-ISSI-SPI-NOR-devices-Additionally-added-several-structs-to-support-ISSI-octal-/20260804-122036 base: https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git spi-nor/next patch link: https://lore.kernel.org/r/LV8PR19MB85976C665A59A0DEBAF4F285B6EF2%40LV8PR19MB8597.namprd19.prod.outlook.com patch subject: [PATCH] Add JEDEC ID table entries for additional ISSI SPI-NOR devices. Additionally added several structs to support ISSI octal flash functionality. (Octal SPI 2026 revised) config: nios2-allmodconfig (https://download.01.org/0day-ci/archive/20260804/[email protected]/config) compiler: nios2-linux-gcc (GCC) 11.5.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260804/[email protected]/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <[email protected]> | Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/ All warnings (new ones prefixed by >>): drivers/mtd/spi-nor/issi.c: In function 'spi_nor_issi_phy_enable': drivers/mtd/spi-nor/issi.c:22:26: error: 'SPINOR_IS_EXSPI' undeclared (first use in this function); did you mean 'SPINOR_OP_EX4B'? 22 | buf[0] = SPINOR_IS_EXSPI; | ^~~~~~~~~~~~~~~ | SPINOR_OP_EX4B drivers/mtd/spi-nor/issi.c:22:26: note: each undeclared identifier is reported only once for each function it appears in In file included from include/linux/mtd/spi-nor.h:11, from drivers/mtd/spi-nor/issi.c:7: drivers/mtd/spi-nor/issi.c:25:59: error: 'SPINOR_OP_IS_WR_ANY_REG' undeclared (first use in this function) 25 | SPI_MEM_OP(SPI_MEM_OP_CMD(SPINOR_OP_IS_WR_ANY_REG, 1), | ^~~~~~~~~~~~~~~~~~~~~~~ include/linux/spi/spi-mem.h:219:24: note: in definition of macro 'SPI_MEM_OP' 219 | .cmd = __cmd, \ | ^~~~~ drivers/mtd/spi-nor/issi.c:25:44: note: in expansion of macro 'SPI_MEM_OP_CMD' 25 | SPI_MEM_OP(SPI_MEM_OP_CMD(SPINOR_OP_IS_WR_ANY_REG, 1), | ^~~~~~~~~~~~~~ drivers/mtd/spi-nor/issi.c:26:52: error: 'SPINOR_REG_IS_CFR0V' undeclared (first use in this function) 26 | SPI_MEM_OP_ADDR(4, SPINOR_REG_IS_CFR0V, 1), | ^~~~~~~~~~~~~~~~~~~ include/linux/spi/spi-mem.h:220:25: note: in definition of macro 'SPI_MEM_OP' 220 | .addr = __addr, \ | ^~~~~~ drivers/mtd/spi-nor/issi.c:26:33: note: in expansion of macro 'SPI_MEM_OP_ADDR' 26 | SPI_MEM_OP_ADDR(4, SPINOR_REG_IS_CFR0V, 1), | ^~~~~~~~~~~~~~~ drivers/mtd/spi-nor/issi.c:36:56: error: 'SPI_CONTROLLER_SDR_PHY' undeclared (first use in this function); did you mean 'SPI_CONTROLLER_NO_RX'? 36 | nor->spimem->spi->controller->flags |= SPI_CONTROLLER_SDR_PHY; | ^~~~~~~~~~~~~~~~~~~~~~ | SPI_CONTROLLER_NO_RX In file included from include/linux/mtd/spi-nor.h:11, from drivers/mtd/spi-nor/issi.c:7: drivers/mtd/spi-nor/issi.c: In function 'spi_nor_issi_octal_dtr_enable': drivers/mtd/spi-nor/issi.c:73:59: error: 'SPINOR_OP_IS_WR_ANY_REG' undeclared (first use in this function) 73 | SPI_MEM_OP(SPI_MEM_OP_CMD(SPINOR_OP_IS_WR_ANY_REG, 1), | ^~~~~~~~~~~~~~~~~~~~~~~ include/linux/spi/spi-mem.h:219:24: note: in definition of macro 'SPI_MEM_OP' 219 | .cmd = __cmd, \ | ^~~~~ drivers/mtd/spi-nor/issi.c:73:44: note: in expansion of macro 'SPI_MEM_OP_CMD' 73 | SPI_MEM_OP(SPI_MEM_OP_CMD(SPINOR_OP_IS_WR_ANY_REG, 1), | ^~~~~~~~~~~~~~ drivers/mtd/spi-nor/issi.c:74:60: error: 'SPINOR_REG_IS_CFR1V' undeclared (first use in this function) 74 | SPI_MEM_OP_ADDR(3, SPINOR_REG_IS_CFR1V, 1), | ^~~~~~~~~~~~~~~~~~~ include/linux/spi/spi-mem.h:220:25: note: in definition of macro 'SPI_MEM_OP' 220 | .addr = __addr, \ | ^~~~~~ drivers/mtd/spi-nor/issi.c:74:41: note: in expansion of macro 'SPI_MEM_OP_ADDR' 74 | SPI_MEM_OP_ADDR(3, SPINOR_REG_IS_CFR1V, 1), | ^~~~~~~~~~~~~~~ drivers/mtd/spi-nor/issi.c:92:32: error: 'SPINOR_IS_OCT_DTR' undeclared (first use in this function) 92 | *buf = SPINOR_IS_OCT_DTR; | ^~~~~~~~~~~~~~~~~ drivers/mtd/spi-nor/issi.c:94:32: error: 'SPINOR_IS_EXSPI' undeclared (first use in this function); did you mean 'SPINOR_OP_EX4B'? 94 | *buf = SPINOR_IS_EXSPI; | ^~~~~~~~~~~~~~~ | SPINOR_OP_EX4B In file included from include/linux/mtd/spi-nor.h:11, from drivers/mtd/spi-nor/issi.c:7: drivers/mtd/spi-nor/issi.c:99:57: error: 'SPINOR_REG_IS_CFR0V' undeclared (first use in this function) 99 | SPINOR_REG_IS_CFR0V, 1), | ^~~~~~~~~~~~~~~~~~~ include/linux/spi/spi-mem.h:220:25: note: in definition of macro 'SPI_MEM_OP' 220 | .addr = __addr, \ | ^~~~~~ drivers/mtd/spi-nor/issi.c:98:41: note: in expansion of macro 'SPI_MEM_OP_ADDR' 98 | SPI_MEM_OP_ADDR(enable ? 3 : 4, | ^~~~~~~~~~~~~~~ drivers/mtd/spi-nor/issi.c:110:35: error: 'SNOR_F_HAS_STACKED' undeclared (first use in this function); did you mean 'SNOR_F_HAS_LOCK'? 110 | if ((nor->flags & SNOR_F_HAS_STACKED) && nor->spimem->spi->cs_index_mask == 1) | ^~~~~~~~~~~~~~~~~~ | SNOR_F_HAS_LOCK drivers/mtd/spi-nor/issi.c: In function 'is25wx256_default_init': drivers/mtd/spi-nor/issi.c:151:58: error: implicit declaration of function 'spi_nor_get_params' [-Werror=implicit-function-declaration] 151 | struct spi_nor_flash_parameter *params = spi_nor_get_params(nor, 0); | ^~~~~~~~~~~~~~~~~~ >> drivers/mtd/spi-nor/issi.c:151:58: warning: initialization of 'struct spi_nor_flash_parameter *' from 'int' makes pointer from integer without a cast [-Wint-conversion] drivers/mtd/spi-nor/issi.c:155:23: error: 'struct spi_nor_flash_parameter' has no member named 'phy_enable' 155 | params->phy_enable = spi_nor_issi_phy_enable; | ^~ drivers/mtd/spi-nor/issi.c: In function 'is25wx256_post_sfdp_fixup': drivers/mtd/spi-nor/issi.c:160:58: warning: initialization of 'struct spi_nor_flash_parameter *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 160 | struct spi_nor_flash_parameter *params = spi_nor_get_params(nor, 0); | ^~~~~~~~~~~~~~~~~~ drivers/mtd/spi-nor/issi.c:165:72: error: 'SPINOR_OP_IS_DTR_RD' undeclared (first use in this function); did you mean 'SPINOR_OP_RDSR2'? 165 | 0, 20, SPINOR_OP_IS_DTR_RD, | ^~~~~~~~~~~~~~~~~~~ | SPINOR_OP_RDSR2 drivers/mtd/spi-nor/issi.c: At top level: drivers/mtd/spi-nor/issi.c:314:30: error: 'USE_FSR' undeclared here (not in a function) 314 | .mfr_flags = USE_FSR, | ^~~~~~~ cc1: some warnings being treated as errors vim +151 drivers/mtd/spi-nor/issi.c 148 149 static void is25wx256_default_init(struct spi_nor *nor) 150 { > 151 struct spi_nor_flash_parameter *params = spi_nor_get_params(nor, 0); 152 153 params->set_octal_dtr = spi_nor_issi_octal_dtr_enable; 154 params->set_4byte_addr_mode = is25wx256_set_4byte_addr_mode; 155 params->phy_enable = spi_nor_issi_phy_enable; 156 } 157 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki