Re: [PATCH] mm: add some missing includes to mm-local headers

On 8/4/26 12:08, Lorenzo Stoakes (ARM) wrote:
> There are a number of internal headers local to mm/ which reference
> functions and data types without including the relevant headers.
> 
> mm/vma.h is a special case that intentionally does not include additional
> headers, but the others are not.
> 
> This breaks tooling like clangd (which is where I noticed this), though the
> build is OK due to the C files including the headers happening to include
> required dependencies.
> 
> It's better to be explicit about dependencies anyway, so add the missing
> includes and fix clangd as a bonus.

I'm curious, how did you identify these? The mm/vmalloc.h is rather easy, but I wonder about
e.g., mm/shuffle.h including mmzone.h.

-- 
Cheers,

David