Re: [PATCH v2 7/8] arm64: dts: fsd: Move 'status' to the end to match coding style

On Sat, 1 Aug 2026 at 16:07, Krzysztof Kozlowski
<[email protected]> wrote:
>
> 'status' property is special, thus DTS coding style expects it to be
> always the last property preceded with a blank line, as reported by
> dt-check-style:
>
>   [required-blank-lines] "status" must be preceded by a blank line
>   [property-order] property 'phy-mode' out of canonical order (should sort before 'status')
>
> Reviewed-by: André Draszik <[email protected]>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---

Reviewed-by: Peter Griffin <[email protected]>

>  arch/arm64/boot/dts/tesla/fsd-evb.dts |  6 ++++--
>  arch/arm64/boot/dts/tesla/fsd.dtsi    | 24 ++++++++++++++++++++++++
>  2 files changed, 28 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/tesla/fsd-evb.dts b/arch/arm64/boot/dts/tesla/fsd-evb.dts
> index 9ff22e1c8723..73b6a25e0e4d 100644
> --- a/arch/arm64/boot/dts/tesla/fsd-evb.dts
> +++ b/arch/arm64/boot/dts/tesla/fsd-evb.dts
> @@ -65,9 +65,10 @@ codec {
>  };
>
>  &ethernet0 {
> +       phy-mode = "rgmii-id";
> +
>         status = "okay";
>
> -       phy-mode = "rgmii-id";
>         fixed-link {
>                 speed = <1000>;
>                 full-duplex;
> @@ -75,9 +76,10 @@ fixed-link {
>  };
>
>  &ethernet1 {
> +       phy-mode = "rgmii-id";
> +
>         status = "okay";
>
> -       phy-mode = "rgmii-id";
>         fixed-link {
>                 speed = <1000>;
>                 full-duplex;
> diff --git a/arch/arm64/boot/dts/tesla/fsd.dtsi b/arch/arm64/boot/dts/tesla/fsd.dtsi
> index 5b06e2667b89..214d33ca7177 100644
> --- a/arch/arm64/boot/dts/tesla/fsd.dtsi
> +++ b/arch/arm64/boot/dts/tesla/fsd.dtsi
> @@ -603,6 +603,7 @@ serial_0: serial@14180000 {
>                                  <&clock_peric PERIC_SCLK_UART0>;
>                         clock-names = "uart", "clk_uart_baud0";
>                         samsung,uart-fifosize = <64>;
> +
>                         status = "disabled";
>                 };
>
> @@ -616,6 +617,7 @@ serial_1: serial@14190000 {
>                                  <&clock_peric PERIC_SCLK_UART1>;
>                         clock-names = "uart", "clk_uart_baud0";
>                         samsung,uart-fifosize = <64>;
> +
>                         status = "disabled";
>                 };
>
> @@ -658,6 +660,7 @@ pwm_0: pwm@14100000 {
>                         #pwm-cells = <3>;
>                         clocks = <&clock_peric PERIC_PWM0_IPCLKPORT_I_PCLK_S0>;
>                         clock-names = "timers";
> +
>                         status = "disabled";
>                 };
>
> @@ -668,6 +671,7 @@ pwm_1: pwm@14110000 {
>                         #pwm-cells = <3>;
>                         clocks = <&clock_peric PERIC_PWM1_IPCLKPORT_I_PCLK_S0>;
>                         clock-names = "timers";
> +
>                         status = "disabled";
>                 };
>
> @@ -681,6 +685,7 @@ hsi2c_0: i2c@14200000 {
>                         pinctrl-0 = <&hs_i2c0_bus>;
>                         clocks = <&clock_peric PERIC_PCLK_HSI2C0>;
>                         clock-names = "hsi2c";
> +
>                         status = "disabled";
>                 };
>
> @@ -694,6 +699,7 @@ hsi2c_1: i2c@14210000 {
>                         pinctrl-0 = <&hs_i2c1_bus>;
>                         clocks = <&clock_peric PERIC_PCLK_HSI2C1>;
>                         clock-names = "hsi2c";
> +
>                         status = "disabled";
>                 };
>
> @@ -707,6 +713,7 @@ hsi2c_2: i2c@14220000 {
>                         pinctrl-0 = <&hs_i2c2_bus>;
>                         clocks = <&clock_peric PERIC_PCLK_HSI2C2>;
>                         clock-names = "hsi2c";
> +
>                         status = "disabled";
>                 };
>
> @@ -720,6 +727,7 @@ hsi2c_3: i2c@14230000 {
>                         pinctrl-0 = <&hs_i2c3_bus>;
>                         clocks = <&clock_peric PERIC_PCLK_HSI2C3>;
>                         clock-names = "hsi2c";
> +
>                         status = "disabled";
>                 };
>
> @@ -733,6 +741,7 @@ hsi2c_4: i2c@14240000 {
>                         pinctrl-0 = <&hs_i2c4_bus>;
>                         clocks = <&clock_peric PERIC_PCLK_HSI2C4>;
>                         clock-names = "hsi2c";
> +
>                         status = "disabled";
>                 };
>
> @@ -746,6 +755,7 @@ hsi2c_5: i2c@14250000 {
>                         pinctrl-0 = <&hs_i2c5_bus>;
>                         clocks = <&clock_peric PERIC_PCLK_HSI2C5>;
>                         clock-names = "hsi2c";
> +
>                         status = "disabled";
>                 };
>
> @@ -759,6 +769,7 @@ hsi2c_6: i2c@14260000 {
>                         pinctrl-0 = <&hs_i2c6_bus>;
>                         clocks = <&clock_peric PERIC_PCLK_HSI2C6>;
>                         clock-names = "hsi2c";
> +
>                         status = "disabled";
>                 };
>
> @@ -772,6 +783,7 @@ hsi2c_7: i2c@14270000 {
>                         pinctrl-0 = <&hs_i2c7_bus>;
>                         clocks = <&clock_peric PERIC_PCLK_HSI2C7>;
>                         clock-names = "hsi2c";
> +
>                         status = "disabled";
>                 };
>
> @@ -789,6 +801,7 @@ i2s_0: i2s@140e0000 {
>                         pinctrl-names = "default";
>                         pinctrl-0 = <&i2s0_bus>;
>                         #sound-dai-cells = <1>;
> +
>                         status = "disabled";
>                 };
>
> @@ -806,6 +819,7 @@ i2s_1: i2s@140f0000 {
>                         pinctrl-names = "default";
>                         pinctrl-0 = <&i2s1_bus>;
>                         #sound-dai-cells = <1>;
> +
>                         status = "disabled";
>                 };
>
> @@ -840,6 +854,7 @@ m_can0: can@14088000 {
>                                  <&clock_peric PERIC_MCAN0_IPCLKPORT_CCLK>;
>                         clock-names = "hclk", "cclk";
>                         bosch,mram-cfg = <0x0 128 64 64 64 64 32 32>;
> +
>                         status = "disabled";
>                 };
>
> @@ -857,6 +872,7 @@ m_can1: can@14098000 {
>                                  <&clock_peric PERIC_MCAN1_IPCLKPORT_CCLK>;
>                         clock-names = "hclk", "cclk";
>                         bosch,mram-cfg = <0x0 128 64 64 64 64 32 32>;
> +
>                         status = "disabled";
>                 };
>
> @@ -874,6 +890,7 @@ m_can2: can@140a8000 {
>                                  <&clock_peric PERIC_MCAN2_IPCLKPORT_CCLK>;
>                         clock-names = "hclk", "cclk";
>                         bosch,mram-cfg = <0x0 128 64 64 64 64 32 32>;
> +
>                         status = "disabled";
>                 };
>
> @@ -891,6 +908,7 @@ m_can3: can@140b8000 {
>                                  <&clock_peric PERIC_MCAN3_IPCLKPORT_CCLK>;
>                         clock-names = "hclk", "cclk";
>                         bosch,mram-cfg = <0x0 128 64 64 64 64 32 32>;
> +
>                         status = "disabled";
>                 };
>
> @@ -909,6 +927,7 @@ spi_0: spi@14140000 {
>                         pinctrl-names = "default";
>                         pinctrl-0 = <&spi0_bus>;
>                         num-cs = <1>;
> +
>                         status = "disabled";
>                 };
>
> @@ -927,6 +946,7 @@ spi_1: spi@14150000 {
>                         pinctrl-names = "default";
>                         pinctrl-0 = <&spi1_bus>;
>                         num-cs = <1>;
> +
>                         status = "disabled";
>                 };
>
> @@ -945,6 +965,7 @@ spi_2: spi@14160000 {
>                         pinctrl-names = "default";
>                         pinctrl-0 = <&spi2_bus>;
>                         num-cs = <1>;
> +
>                         status = "disabled";
>                 };
>
> @@ -1007,6 +1028,7 @@ ethernet1: ethernet@14300000 {
>                                     <&eth1_rx_ctrl>, <&eth1_mdio>;
>                         local-mac-address = [00 00 00 00 00 00];
>                         iommus = <&smmu_peric 0x0 0x1>;
> +
>                         status = "disabled";
>                 };
>
> @@ -1026,6 +1048,7 @@ ufs: ufs@15120000 {
>                         pinctrl-0 = <&ufs_rst_n &ufs_refclk_out>;
>                         phys = <&ufs_phy>;
>                         phy-names = "ufs-phy";
> +
>                         status = "disabled";
>                 };
>
> @@ -1056,6 +1079,7 @@ ethernet0: ethernet@15300000 {
>                                     <&eth0_rx_ctrl>, <&eth0_mdio>;
>                         local-mac-address = [00 00 00 00 00 00];
>                         iommus = <&smmu_fsys0 0x0 0x1>;
> +
>                         status = "disabled";
>                 };
>         };
>
> --
> 2.53.0
>