Re: [PATCH 1/2] hung_task: Reset warning budget when problem gets resolved
Aaron Tomlin <[email protected]>
| Newsgroups | gmane.linux.kernel |
|---|---|
| Message-ID | <k35ypho43jq6n4h44qospcdrj5fpbph46pqfrfw3j6s56hszch@u2qgtmo5hexa> |
On Tue, Aug 04, 2026 at 10:24:01AM +0800, Lance Yang wrote: > On 2026/8/4 08:15, Aaron Tomlin wrote: > > From: Petr Mladek <[email protected]> > > > > sysctl_hung_task_warnings counts how many hung tasks are reported. > > The watchdog does not report anything once the limit is reached. > > Currently, this budget is decremented permanently, meaning the kernel is > > left blind to subsequent hung tasks even after the original issue resolves. > > > > Keep the global sysctl_hung_task_warnings intact, and instead decrement > > a copy (hung_task_warnings_printed) when warnings are printed. Reset > > the copy back to the configured sysctl_hung_task_warnings limit once the > > problem on the system gets resolved and check_hung_uninterruptible_tasks() > > detects no hung tasks in a check interval. > > > > Also keep the copy updated when the global sysctl_hung_task_warnings > > value is updated via sysctl, and update documentation to reflect > > the new behavior. > > > > Assisted-by: gemini-3.5-flash > > Signed-off-by: Petr Mladek <[email protected]> > > Was a bit surprised not to see any tag from you here. I’d assumed you’d > be taking this through testing and spinning v7, so I expected your SoB + > Suggested-by Petr. > > Keeping both SoBs works too; either way, you’ve definitely earned yours > here. > > Assisted-by: gemini-3.5-flash > Suggested-by: Petr Mladek <[email protected]> > Signed-off-by: Aaron Tomlin <[email protected]> > > Same goes for patch #02, btw :) > > Thanks, Lance Hi Lance, Thank you. I will prepare a v7 with the above. Also, include your "Reviewed-by:" tag. Kind regards, -- Aaron Tomlin
signature.asc
(application/pgp-signature, 833 B)
-----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEeQaE6/qKljiNHm6b4t6WWBnMd9YFAmpx9PMACgkQ4t6WWBnM d9aLURAAqkm/f5masNh0ojapbUOTR4sC61AK3H2iJRdQOlloDch5gMc71Cf+0bvN iUBub6O1+gt2wDg0dz/y/fx5yDqwGJnEOIyVI+C8WZkKDTBa+o3uVHKMhNG1rzN0 Bcp1JPU2FMlFwJA062hqBjRU7HDiMvTXRVfDiyaLJSCP7yfb0KO1ShuNDn2t9wOn c8JoWX7CUeklkRk3Hk5PiuP8mebyRPRnIqoLfrQMUG6jMbCGZUFJg/RoXP2Dm7Ux 1KPwZecGzNSYGWnwhBPqVKuqg1dCHlTMaC95bTb/35SI87a0NeA0GUItJR4VKgSq 5Wvpwj3uRNnXW/Rwn4gfJexFBywS4LG0NGWSIyyIiIk9zKjOGm3lf4z2XysQRkj1 j+XOxk3g+5pRU3jrZI+kM4MNBbUkdsn6Oo8znqIXdcPFcO+TEFHuLRAMcAIIQk9+ INvzcRT9g7doWwDzxywsRQbVd339W+R7ZkQwcZEgrT7MASci0107WWC3Ai/QeGgR mh3eXHXjFzZ9ecMaytP9NhuVOUATXJk/XqsxhNqZOmRDp2M/3JFm7LNXjClvXM7E QcqDXbj15jXFdeSg5tJhhF7fcmcgBFtwoKG9Me9YlISLqkhG663Q2ReQ0qExrNRI lEu/OIYNof4DJp4sXwf2M/UbFl6lwk7TVV+FKM05XTIZKVF0o7A= =9aKi -----END PGP SIGNATURE-----