Re: [PATCH net v2 2/3] net: devmem: return EMSGSIZE on type mismatch

On Mon, Aug 3, 2026 at 12:54 PM Jakub Kicinski <[email protected]> wrote:
>
> On Mon,  3 Aug 2026 17:14:40 +0000 Mina Almasry wrote:
> > When a devmem payload mixes with a standard page payload, return
> > -EMSGSIZE instead of -EFAULT. This enables tcp_sendmsg to seamlessly
> > fall back to creating a new segment instead of failing the socket send.
>
> Sure but AFAIU this was discovered during a ML discussion,
> so the change is an improvement for net-next rather than a fix.
> Do you have any reason to believe that real applications hit
> the error?
>

No, I don't have a reason; I just thought it was a straightforward fix
you might want to take in net. I can definitely punt this to net-next.
I'm a bit unsure whether you want this series reposted as v3 without
this patch, or if you're going to take the other 2 patches. I guess if
I don't see the rest merged I'll repost. Thanks!

> Also please add cover letters for submissions with more than 2 patches.

Will do, thanks! I'm slightly unsure about a commit message that
basically says "Here a bunch of fixes to devmem reported by sashiko.",
but I'll give that a shot.

-- 
Thanks,
Mina