[PATCH v9 18/36] pinctrl: airoha: add missed IRQ resource helpers
Mikhail Kshevetskiy <[email protected]>
| Newsgroups | gmane.linux.kernel.gpio,gmane.linux.drivers.devicetree,gmane.linux.kernel,gmane.linux.ports.arm.mediatek |
|---|---|
| Message-ID | <[email protected]> |
Without hooking .irq_request_resources, gpiolib cannot set
GPIOD_FLAG_USED_AS_IRQ. This breaks pin direction locking and can allow
userspace or another driver to reconfigure an active IRQ pin as an output
Fixes: 1c8ace2d0725 ("pinctrl: airoha: Add support for EN7581 SoC")
Signed-off-by: Mikhail Kshevetskiy <[email protected]>
Acked-by: Lorenzo Bianconi <[email protected]>
---
drivers/pinctrl/airoha/pinctrl-airoha.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/airoha/pinctrl-airoha.c b/drivers/pinctrl/airoha/pinctrl-airoha.c
index 8895a8123c621..b4c61fa811fb1 100644
--- a/drivers/pinctrl/airoha/pinctrl-airoha.c
+++ b/drivers/pinctrl/airoha/pinctrl-airoha.c
@@ -2689,6 +2689,7 @@ static const struct irq_chip airoha_gpio_irq_chip = {
.irq_mask_ack = airoha_irq_mask,
.irq_set_type = airoha_irq_type,
.flags = IRQCHIP_SET_TYPE_MASKED | IRQCHIP_IMMUTABLE,
+ GPIOCHIP_IRQ_RESOURCE_HELPERS,
};
static int airoha_pinctrl_add_gpiochip(struct airoha_pinctrl *pinctrl,
--
2.53.0