Re: [PATCH] iio: adc: twl4030-madc: read MADC_CTRL1 from the correct module
Joshua Crofts <[email protected]>
| Newsgroups | gmane.linux.kernel.iio,gmane.linux.kernel |
|---|---|
| Message-ID | <[email protected]> |
On Wed, 5 Aug 2026 16:31:59 +0400 Giorgi Tchankvetadze <[email protected]> wrote: > From: Giorgi Tchankvetadze <giorgi-jm0GIMhvZptR7elET7xKoQC/[email protected]> > > twl4030_madc_set_power() does a read-modify-write on MADC_CTRL1 but > reads it from TWL_MODULE_MAIN_CHARGE while writing it back to > TWL4030_MODULE_MADC. > > Fix it by reading MADC_CTRL1 from TWL4030_MODULE_MADC > so the read-modify-write operates on the register's actual > contents. > > Fixes: f99c1d4f94f9 ("mfd: Add twl4030 madc driver") > Signed-off-by: Giorgi Tchankvetadze <giorgi-jm0GIMhvZptR7elET7xKoQC/[email protected]> > --- This makes sense. Reviewed-by: Joshua Crofts <[email protected]> -- Kind regards, Joshua Crofts