Re: [PATCH v4 3/6] iio: dac: ad5504: remove legacy platform data support
Andy Shevchenko <[email protected]>
| Newsgroups | gmane.linux.kernel.iio,gmane.linux.drivers.devicetree,gmane.linux.kernel |
|---|---|
| Organization | Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo |
| Message-ID | <[email protected]> |
On Mon, Aug 17, 2026 at 05:11:12PM -0400, Taha Ed-Dafili wrote:
> The AD5504 driver contains fallback logic to use legacy pdata for
> configuration. Since modern systems configure hardware exclusively
> using device tree or ACPI, and there are no in tree users for it.
> It can be safely removed.
>
> Drop the ad5504_platform_data structure, remove the fallback logic
> from the probe function, and delete the dedicated
> include/linux/iio/dac/ad5504.h header file.
This breaks the case with dummy regulators as far as I can see.
Has this been discussed in the previous rounds?
...
> - if (ret == -ENODEV) {
> - else
> - dev_warn(dev, "reference voltage unspecified\n");
This one.
...
In general it's a good change.
--
With Best Regards,
Andy Shevchenko