Re: [PATCH 29/45] clk: samsung: Make sure clk_init_data is fully initialized
Krzysztof Kozlowski <[email protected]>
| Newsgroups | gmane.linux.kernel.clk,gmane.linux.ports.arm.kernel,gmane.linux.kernel,gmane.comp.hardware.openbmc,gmane.linux.ports.mips,gmane.linux.kernel.renesas-soc,gmane.linux.ports.arm.rockchip,gmane.linux.kernel.samsung-soc,gmane.linux.ports.tegra,gmane.linux.ports.arm.mediatek |
|---|---|
| Message-ID | <[email protected]> |
On 21/08/2026 10:53, Geert Uytterhoeven wrote: > The clk_init_data structure contains several mutually-exclusive members > for different methods to specify the possible parents of a clock, > prompting drivers to initialize only the members they need. However, > not initializing all members may cause subtle issues, which are only > exposed when CONFIG_INIT_STACK_ALL_PATTERN or CONFIG_INIT_STACK_NONE is > enabled. > > Make sure all members are fully initialized, to avoid such bugs, and to > prevent future breakage when converting drivers to a different method > for specifying the parents. > > Signed-off-by: Geert Uytterhoeven <[email protected]> > --- > Compile-tested only. > --- > drivers/clk/samsung/clk-cpu.c | 2 +- > drivers/clk/samsung/clk-pll.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Krzysztof Kozlowski <[email protected]> Let me know if I should take it via Samsung SoC clock tree. I assume by default this will go directly via clock tree. Best regards, Krzysztof