Re: [PATCH v2 1/3] dt-bindings: phy: qcom,snps-eusb2-phy: Document the Nord eUSB2 PHY
Krzysztof Kozlowski <[email protected]>
| Newsgroups | gmane.linux.drivers.devicetree,gmane.linux.ports.arm.msm,gmane.linux.kernel |
|---|---|
| Message-ID | <20260918-cheerful-independent-saluki-208ce3@quoll> |
On Wed, Sep 16, 2026 at 08:30:51PM +0200, Bartosz Golaszewski wrote: > Add a compatible for the eUSB2 PHY found on the Qualcomm Nord SoC. > It is compatible with the sm8550 eUSB2 PHY. > > While at it: On Nord SoC there are three eUSB2 PHYs but only two QUSB2PHY > block resets: the HS-only USB20 tile has no dedicated PHY reset and is > instead reset as a whole through the controller's own USB20_PRIM_BCR. > > Make the 'resets' property optional. So this is a correct explanation for Nord, but you do much more than explained here. You make it optional for Eliza, Milos and every other device but use "Nord" as an argument. It's wrong argument. Eliza is different than Nord. This either needs proper explanation or a fix - you need constraints per variants (allOf:if:then). Best regards, Krzysztof