[PATCH v5 12/15] crypto: ti - Do AEAD software fallback on only ENOMEM
T Pratham <[email protected]>
| Newsgroups | gmane.linux.kernel,gmane.linux.kernel.cryptoapi |
|---|---|
| Message-ID | <[email protected]> |
Similarly in how AES part of this driver, we are falling back to
software when memory allocation fails (we get -ENOMEM), fix the AEAD
part also to only do fallback when we fail only due to -ENOMEM. This is
because we are doing memory allocations with GFP_ATOMIC in the beginning
which might fail. Any other failure paths might have modified the data
or buffers already. Doing a software fallback on them might give
incorrect or corrupt results.
Fixes: 37b902c603042 ("crypto: ti - Add support for AES-GCM in DTHEv2 driver")
Signed-off-by: T Pratham <[email protected]>
---
drivers/crypto/ti/dthev2-aes.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/ti/dthev2-aes.c b/drivers/crypto/ti/dthev2-aes.c
index a034c1c8f20ed..150ce65f613fa 100644
--- a/drivers/crypto/ti/dthev2-aes.c
+++ b/drivers/crypto/ti/dthev2-aes.c
@@ -1173,7 +1173,7 @@ static int dthe_aead_run(struct crypto_engine *engine, void *areq)
aead_prep_aad_err:
memzero_explicit(rctx->padding, 3 * AES_BLOCK_SIZE);
- if (ret)
+ if (ret == -ENOMEM)
ret = dthe_aead_do_fallback(req);
local_bh_disable();
--
2.34.1