Re: [PATCH v8 5/8] Loongson: YeeLoong: add hardware monitoring driver

Pavel Machek <[email protected]>
Newsgroups gmane.linux.laptop,gmane.linux.ports.mips.general,gmane.linux.kernel
Message-ID <[email protected]>
Hi!

> +static int get_battery_current(void)
> +{
> +	s16 value;
> +
> +	value = (ec_read(REG_BAT_CURRENT_HIGH) << 8) |
> +		(ec_read(REG_BAT_CURRENT_LOW));
> +
> +	if (value < 0)
> +		value = ~value + 1;
> +
> +	return value;
> +}

What is going on here? I thought the value is already in two's
complement... Is the above equivalent of

	      if (value < 0)
	      	 value = -value; 

? If so, why? If not, can you add a comment?
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-laptop" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.