Re: 5.2-trunk seems to be unstable.

Hi.

16.08.2015 13:08, Erich Titl пишет:
> Hi Andrew
>
> Am 15.08.2015 um 17:50 schrieb Andrew:
>> After month of uptime I've got crash again. It seems that crash caused
>> by shaper removing from ppp interface before it's deletion, which causes
>> race condition.
>
> Why does this cause a race condition? You should be able to remove a 
> shaper without the system crashing.
>
Interface is shutted down and destroyed, and before this - shaper qdiscs 
were deleted by script. This isn't required, in any case on ip-up we 
also tried to delete root/ingress qdisc before creating new shaper classes.

I think that either accel-ppp doesn't wait for ip-down script 
termination before deleting interface, or kernel cleans structures 
asynchronously without locks - so in some cases kernel tries to remove 
shaper twice simultaneously, that causes bug.
> Did you get a response from kernel.org?
>
No, still no response. Here is bug: 
https://bugzilla.kernel.org/show_bug.cgi?id=100971
>>
>> I removed shaper delete from scripts, and I think that this'll fix bug.
>
> No it just avoids it.
In any case, alternative - wait for fix in upstream - isn't a good idea 
(no response for month).
Other accel-ppp user said that he has no troubles with it - he has no 
shaper cleanup on shutdown.
>
> cheers
>
> Erich
>
>
>
>
> ------------------------------------------------------------------------------
>
>
> _______________________________________________
> leaf-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/leaf-devel

------------------------------------------------------------------------------

_______________________________________________
leaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/leaf-devel