Re: cat: vim-test.log: No such file or directory

Le samedi 08 février 2025 à 17:32 +0100, Pierre Labastie a écrit :
> Le vendredi 07 février 2025 à 21:43 -0600, Bruce Dubbs a écrit :
> > On 2/7/25 9:14 PM, Xi Ruoyao ([email protected] via alfs-discuss
> > Mailing List) wrote:
> > > On Fri, 2025-02-07 at 21:09 -0600, Bruce Dubbs wrote:
> > > > On 2/7/25 6:12 PM, Xi Ruoyao ([email protected] via alfs-
> > > > discuss
> > > > Mailing List) wrote:
> > > > > On Fri, 2025-02-07 at 16:00 -0600, Bruce Dubbs wrote:
> > > > > > On 2/7/25 3:44 PM, "md" ([email protected] via alfs-
> > > > > > discuss Mailing List) wrote:
> > > > > > > Hi,
> > > > > > > 
> > > > > > > I'm running "make mk_CHROOT" using
> > > > > > > jhalfs: a4a8cc86b547c4f00e90c7a0cb50304a2f286cb4 (HEAD ->
> > > > > > > trunk, origin/trunk,
> > > > > > > origin/HEAD) Fix generation of test instructions
> > > > > > > and
> > > > > > > lfs: 40ca48d44fb8794633a466015ab5b34f978bf2c6 (HEAD ->
> > > > > > > trunk, origin/trunk,
> > > > > > > origin/HEAD) binutils: Drop stale references to gold
> > > > > > > 
> > > > > > > and getting
> > > > > > > cat logs/871-vim-9.1.1071 | tail -4
> > > > > > > link.sh: Linked fine
> > > > > > > make[2]: Leaving directory '/sources/vim-9.1.1071/src'
> > > > > > > make[1]: Leaving directory '/sources/vim-9.1.1071'
> > > > > > > cat: vim-test.log: No such file or directory
> > > > > > > 
> > > > > > > Here is the relevant part of lfs-commands/chapter08/871-
> > > > > > > vim
> > > > > > > ...
> > > > > > > make
> > > > > > > # chown -R tester . >> $TEST_LOG 2>&1 || true
> > > > > > > # sed '/test_glvs/d' -i src/testdir/Make_all.mak >>
> > > > > > > $TEST_LOG 2>&1 || true
> > > > > > > # su tester -c "TERM=xterm-256color LANG=en_US.UTF-8 make
> > > > > > > -
> > > > > > > k -j1 test" \
> > > > > > > #    &> vim-test.log || true
> > > > > > > cat vim-test.log >> $TEST_LOG
> > > > > 
> > > > > So the issue is jhalfs should not insert this command when
> > > > > tests are
> > > > > disabled.
> > > > 
> > > > Every package gets something in jhalfs/test-logs/.
> > > 
> > > /* snip */
> > > 
> > > It's vim-test.log, which is created by the book, not jhalfs (i.e.
> > > NOT
> > > test-logs/871-vim-9.1.1071).  But the book does not have the cat
> > > vim-
> > > test.log >> $TEST_LOG command.
> > 
> > Correct.  That last line is specific to jhalfs.
> > 
> > > And as the 4 commented lines are commented, we don't have the
> > > vim-
> > > test.log file.  Thus the build process fails (as jhalfs sets set
> > > -
> > > e).
> > 
> > Hmm, yes.  I guess if should be "if -e vim-test.log then do cat
> > vim-
> > test.log >> 
> > $TEST_LOG; fi"
> > 
> > Or add another line: 'touch vim-test.log'
> > 
> > I like the second one.
> 
> I think I'll just keep the line, and comment it out if the tests are
> disabled. Sorry for the bug...

Fixed at commit 3482b3c16
Thanks for report and discussion

Pierre

-- 
http://lists.linuxfromscratch.org/sympa/info/alfs-discuss
Unsubscribe: See the above information page