[jhalfs] 02/02: func_download_pkgs: fix spurious error whith empty md5 sum

"Git Owner" ([email protected] via alfs-discuss Mailing List) <[email protected]> Thu, 18 Sep 2025 12:37:27 +0000
Newsgroups gmane.linux.lfs.automated
Message-ID <[email protected]>
This is an automated email from the git hooks/post-receive script.

git pushed a commit to branch trunk
in repository jhalfs.

commit 69eb5e74e91728788726261b2e509d178eb7697c
Author: Pierre Labastie <[email protected]>
AuthorDate: Thu Sep 18 14:32:34 2025 +0200

    func_download_pkgs: fix spurious error whith empty md5 sum
    
    If BOOKMD5 is empty, there is a bash error in lines 84 and 85.
    This may be misleading, since the basic problem is a wrong md5,
    which is detected in the code following those lines. Add quotes
    to prevent the error.
    By-product of error reported by Marcin Dulak in
    https://lists.linuxfromscratch.org/sympa/arc/alfs-discuss/2025-09/msg00002.html
---
 common/libs/func_download_pkgs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/common/libs/func_download_pkgs b/common/libs/func_download_pkgs
index 4e0edf4..c26a41b 100644
--- a/common/libs/func_download_pkgs
+++ b/common/libs/func_download_pkgs
@@ -81,8 +81,8 @@ get_sources() {              # Download file, write name to MISSING_FILES.DMP if
 
     # Deal with bootscripts md5sum issue,
     # or skip if it is a custom patch without md5
-    [ $BOOKMD5 = "BOOTSCRIPTS-MD5SUM"  ] && continue
-    [ $BOOKMD5 = "CUSTOM-PATCH-MD5SUM" ] && continue
+    [ "$BOOKMD5" = "BOOTSCRIPTS-MD5SUM"  ] && continue
+    [ "$BOOKMD5" = "CUSTOM-PATCH-MD5SUM" ] && continue
 
       # IF the md5sum does not match
     if ! echo "$MD5" | md5sum -c - >/dev/null ; then

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.

-- 
http://lists.linuxfromscratch.org/sympa/info/alfs-discuss
Unsubscribe: See the above information page