[BLFS Trac] #23211: x265-4.2
| Newsgroups | gmane.linux.lfs.beyond.book |
|---|---|
| Message-ID | <[email protected]> |
#23211: x265-4.2
-------------------------+-----------------------
Reporter: zeckma | Owner: blfs-book
Type: enhancement | Status: new
Priority: elevated | Milestone: 13.1
Component: BOOK | Version: git
Severity: normal | Keywords:
-------------------------+-----------------------
New minor version.
This release fixes a memory leak, and fails to build for 32-bit, both for
multilib and on i?86.
The fix for the 32-bit issue is quite simple:
{{{
diff '--color=auto' -Naur x265_4.2.orig/source/common/x86/cpu-a.asm
x265_4.2/source/common/x86/cpu-a.asm
--- x265_4.2.orig/source/common/x86/cpu-a.asm 2026-04-19
00:29:17.000000000 -0600
+++ x265_4.2/source/common/x86/cpu-a.asm 2026-04-28
14:13:19.668692866 -0600
@@ -177,7 +177,7 @@
%if WIN64
lea rax, [intel_cpu_indicator_init]
call rax
-%elif FORMAT_ELF
+%elif UNIX64 && FORMAT_ELF
call [rel intel_cpu_indicator_init wrt ..plt]
%else
call intel_cpu_indicator_init
}}}
`UNIX64` in the code was switched to `FORMAT_ELF` to adjust for MacOS. But
now the code doesn't check what the architecture is, which is important
since i?86 cannot do PLT, which the condition goes through if true. So
both the architecture and format needs to be checked. With this change,
both 64-bit and 32-bit compiles fine.
The issue covering this build failure is discussed here:
https://bitbucket.org/multicoreware/x265_git/issues/1030/42-build-fails-
on-i686-elf-format-cannot.
--
Ticket URL: <https://wiki.linuxfromscratch.org/blfs/ticket/23211>
BLFS Trac <https://wiki.linuxfromscratch.org/blfs/>
Beyond Linux From Scratch
--
http://lists.linuxfromscratch.org/sympa/info/blfs-book
Unsubscribe: See the above information page