Re: good patch vs. sed fixes

Hi,

On Thu, 21 Nov 2024, Joe Locash wrote:

> On 11/20/24 9:40 PM, Uwe DÃŒffert ([email protected] via blfs-dev 
> Mailing List) wrote:
>> 
>> I'm not sure it is worth the effort, but from time to time I stumble across 
>> the "problem" that certain sed or patch commands would apply multiple times 
>> although they should not.
>
> I'd like to see an example of where a patch can be applied more than once.
Here you go: The only case I know of for sure is
qt-everywhere-opensource-src-5.15.15-kf5-1.patch
Not sure if self-created by Pierre instructions or more official.
But it is a unified patch and a part of it applies multiple times.
As qt5 as well as the patch is rather big, you do not easily spot the
difference, you carefully have to watch the patch output. (And then 
restart from scratch as you broke the source in a way you do not want to 
revert manually). The counter measure in my build script was to only patch 
if qtbase/.git did not exist yet, which was created in the next line of 
the script, i.e. a clear sign I ran the script / patched before...

Uwe

-- 
http://lists.linuxfromscratch.org/sympa/info/blfs-dev
Unsubscribe: See the above information page